Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new403 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
kristen pol’s picture

Vighneshh made their first commit to this issue’s fork.

vighneshh’s picture

Assigned: Unassigned » vighneshh

will review

vighneshh’s picture

Assigned: vighneshh » Unassigned
StatusFileSize
new14.45 KB

Reviewed and tested by applying the patch
everything looks fine and the module is compatible with drupal 10.
Adding a screenshot of the scan results.

kristen pol’s picture

Issue tags: +Needs manual testing

Thanks for participating in porting day! Tagging for manual testing on Drupal 10. See instructions here:

https://www.drupal.org/community-initiatives/contribution-events-initiat...

mglaman’s picture

Status: Needs review » Needs work
Fatal error: Declaration of Drupal\Tests\config_ignore\Kernel\IgnoreKernelTest::setUp() must be compatible with Drupal\KernelTests\KernelTestBase::setUp(): void in /Users/matt.glaman/Sites/d10verify/web/modules/contrib/config_ignore/tests/src/Kernel/IgnoreKernelTest.php on line 40
mglaman’s picture

Status: Needs work » Needs review
StatusFileSize
new2.08 KB

Rector didn't have a rule to fix public static $modules to protected static $modules on the last bot run. And the whole fixing of setUp(): void is hit or mess due to Drupal auto-fixing it in the base class. This addresses remaining items.

mglaman’s picture

StatusFileSize
new2.48 KB

Blah, I forgot that Drupal CI fails on Drupal 10 unless the composer.json gets modified. Minor edit of composer.json to replace http:// with https:// :P

nkoporec’s picture

Status: Needs review » Reviewed & tested by the community

The patch looks okay and tests passes, setting as RTBC.

  • bircher committed bbdb8d3 on 8.x-2.x
    Issue #3286656 by mglaman, Vighneshh, Project Update Bot, Kristen Pol,...
bircher’s picture

Status: Reviewed & tested by the community » Fixed

Thanks everyone!

bircher’s picture

Status: Fixed » Active

Active so that the bot could post patches again.. just in case..

kristen pol’s picture

Issue tags: -Needs manual testing

Thanks for helping on porting day!

Removing testing tag.

alex.skrypnyk’s picture

@bircher

Can this please be released so that other modules that depend on this one and already ported to D10 could use this one. Thank you

project update bot’s picture

Issue summary: View changes

ankitv18 made their first commit to this issue’s fork.

eelkeblok’s picture

Issue summary: View changes

Looks like MR !13 is the same as what is already committed to the 2.x branch.

ankitv18’s picture

Status: Active » Reviewed & tested by the community

Yes, thanks @eelkeblok I guess we can mark this RTBC
dev release is already there, user can use this via composer require drupal/config_ignore:3.x-dev@dev
@tlyngej @bircher @nord102 when can we have a release for D10.

smustgrave’s picture

Hello following up on #21 if we could get a release for D10 please.

markdorison’s picture

A release with these changes included for D10 would be very much appreciated!

rajab natshah’s picture

Priority: Normal » Major
jsacksick’s picture

This is the last module I'm using on my projects that doesn't have a tagged release compatible with Drupal 10.

bircher’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.