Update to D9 core 9.4.x

I put some more runs on 9.4.0-beta1 , so far so good.

Less patches required, more issues resolved.

rerolled

I suggest a 4.4.x branch soon so that we can start putting it through it's paces but as you wish.

it will need a very minor reroll again once 4.3.x is updated to last nights build https://www.drupal.org/project/drupal/releases/9.3.16

9.4.0 broke this patch:

#1356276-680: Allow profiles to define a base/parent profile

needs a reroll

rerolled

9.4.1 was released, here's a reroll.

** edit **
comment was not relevant to the 9.4.x upgrade, moving it to another issue.
** end edit **

Wondering on a timeline for the 4.4.x branch? How soon can we expect it?

Just wondering if we should be overriding 4.3.x for our project or wait until 4.4.x is released?

assuming 4.3.1 is tagged and released soon with D9.3.19, updating the patch here to upgrade from 9.3.19 to 9.4.3

patch #18 still applies cleanly against 4.3.2 or current HEAD of 4.3.x
reviewing

re-reviewing this now

New patch.

patch 20 (should have been labelled 21 sorry) applies cleanly to head and also doing rm composer.lock; composer install; it installs cleanly no patch conflicts.

The one patch that was removed was fixed 6 months ago in 9.4.x so therefore it is no longer needed.

#3184667: Node form layout looks awkward on wide screens since #3158854

Less and less need for patches, this is good!

D9.4.5 version reroll

interdiff is basically one line, instead of 9.4.3 , 9.4.5

@sylus, can we expect a 9.4.x release soon? just wondering if I should override our composer.json now or wait for a 4.4.x WxT release?
I am being asked this question. D9.4.x is the recommended core .

look at adding this patch to the 9.4.x release
#3107212-13: views no results behavior on field level is not translateable

another one to look at (possible reroll for this patch if necessary)
#3236799: Canada.ca flyout menu doesn't work?

consider adding this one also
#3150294-109: New translations for moderated nodes are not created in the initial workflow state

Ok new patch. This is for wxt similar to the above patches except I added two core patches mentioned in comment #27 and #29:

Here's the interdiff.

diff --git a/composer.json b/composer.json
index 8e084ea..5b440cc 100644
--- a/composer.json
+++ b/composer.json
@@ -208,8 +208,12 @@
                 "https://www.drupal.org/files/issues/2019-01-18/2938129-pagetitle-11.patch",
                 "Enter drupal/core patch #3017710 description here":
                 "https://www.drupal.org/files/issues/2018-12-05/3017710-20.patch",
+                "3016131 - Improved exception message developer experience":
+                "https://www.drupal.org/files/issues/2020-05-26/drupal-3016131-23-useless-exception.patch",
+                "3107212 - Views no results behavior on field level translation fix.":
+                "https://www.drupal.org/files/issues/2022-03-09/d9-4-x--3107212-13.patch",
                 "3150294 - New translations for moderated nodes are not created in the initial workflow state":
-                "https://www.drupal.org/files/issues/2022-01-05/3150294-95.patch",
+                "https://www.drupal.org/files/issues/2022-05-11/3150294-109.patch",
                 "3177182 - Book title in breadcrumb not translated":
                 "https://www.drupal.org/files/issues/2020-10-20/book-breadcrumb_title_xlate-3177182-3.patch",
                 "Enter drupal/core patch #3173808 description here":

I've basically done something similar in overrides, overridden 4.3.0 with D9.4.5 instead of 9.3.16, with a similar list of patches, so far it's good.

Using PHP 8.1 btw, applied patches for wxt_library and bootstrap for that one, not yet adventurous enough to try wxt 4.3.2, going with core upgrade first.

D9.4 with PHP 8.1 needs quite a few contrib updates also

simple_sitemap needs the 4.x branch instead of 3.x and/or the patch from this issue:
#3299827: php8.1 compatibility - Passing null to parameter #1 ($string) of type string is deprecated

webform 6.1.x needs this patch #3279930: Deprecated function: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in webform_requirements()
OR upgrade webform from 6.1x to 6.2.x

to name a few

overrode core using wxt 4.3.0 and testing 9.4.5 using php 8.1 , so far only one deprecated warning left to resolve and I'm not sure where it's comming from but there were many fixed by patching a couple contrib modules , I'll update the patch again for this soon.

with PHP 8.0 patch 29 should do the job, for PHP 8.1 I'll provide another patch.

patches for webform 6.2.x recommended with 9.4.5 and PHP 8.1

3279930 - PHP 8.1
Source: https://www.drupal.org/files/issues/2022-05-11/webform-strpos-php81-webform-requirements-3279930-2.patch

3301970 - PHP 8.1 deprecation
Source: https://www.drupal.org/files/issues/2022-08-05/3301970_2.patch

fix 404 not found date-calendar.png
Source: https://www.drupal.org/files/issues/2022-08-11/webform-3303194-02.patch

Enter drupal/webform patch #3205860 description here
Source: https://www.drupal.org/files/issues/2021-03-26/webform_clientside_validation-3205860-2.patch

Patch 29 works well with PHP 8.0, D9.4.5

I recommend people go with PHP 8.0 and 9.4.5, this will allow us to move forward in a timely manner.

PHP 8.0 works nicely no fuss. 9.4.5 also works well. Is there anything else needed before commit?

Patch 29 should be easy enough to apply.

just as a FYI, I haven't upgraded any sites to 4.3.3 yet because we need 9.4.x and we've overridden 4.3.0 to install D9.4.5

Unfortunately I haven't had time to test 4.3.3. We're basically waiting for 9.4.x to be integrated before upgrading.

I was hoping to be upgraded to the latest wxt however due to the core lagging behind we took matters into our own hands and overrode it. Due to the base project child project setup we have I'd prefer to postpone upgrading our wxt until it contains 9.4.x.

patch needs a slight adjustment, D9.4.6 was released

it's a bug fix release, highly recommend using 9.4.6 instead of 9.4.5, I looked at the release notes and it fixes annoyances that I ran into when upgrading to 9.4.5

so upgrading to 9.4.6 from 9.3.21 should be painless.

new patch

no interdiff is needed, just changed 9.4.5 to 9.4.6

The latest twig/twig requires Drupal 9.4.7 to work properly. I haven't tested 9.3.22 yet though but it's broken on 9.3.21.

#3312270: Twig LoaderError after upgrading Twig to 2.15.3

#3230673-28: [WxT5] compatibility with Layout Builder.

FYI: 9.4.8 was released.

@sylus thanks for jamming this in and @smulvih2 for testing it out several times.