Problem/Motivation

There are several references to Bartik and Seven:

4 core/tests/Drupal/FunctionalJavascriptTests/Ajax/AjaxTest.php

These tests should be updated to either use Olivero, Claro, or System module's test_theme so we can deprecate Bartik #3249109: Deprecate Bartik and Seven #3084814: Deprecate Seven theme as mentioned at #3278124: Convert various tests that use bartik/seven to olivero/claro.

Steps to reproduce

git grep -E '(bartik)|(seven)' -- 'core/tests/Drupal/FunctionalJavascriptTests/Ajax' | awk -F: '{print $1}' | sort | uniq -c should return no results when this work is complete.

Remaining tasks

Update the tests.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

I don't think we need release notes or a change record.

CommentFileSizeAuthor
#2 3281451-2-10.0.x.patch1.49 KBtinto
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

deviantintegral created an issue. See original summary.

tinto’s picture

tinto
Location Amsterdam
CreditAttribution: tinto at The Savvy Few commented
Status: Active » Needs review
FileSize
3281451-2-10.0.x.patch1.49 KB

Adding patch to update core/tests/Drupal/FunctionalJavascriptTests/Ajax/AjaxTest.php. It contains four mentions of the Seven theme, so I'm replacing them with Claro.

daffie’s picture

daffie CreditAttribution: daffie commented
Parent issue: #3281449: Update Core unit tests to not use Bartik and Seven » #3285205: [META] Convert test that use Bartik/Seven to Olivero/Claro

Assign this issue to the parent #3285205: [META] Convert test that use Bartik/Seven to Olivero/Claro.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed ed4df467ee to 10.0.x and 98391f658f to 9.5.x and cf48246a79 to 9.4.x. Thanks!

As a test only change backported to 9.4.x

  • alexpott committed ed4df46 on 10.0.x 
    Issue #3281451 by tinto: Update Ajax FunctionalJavascript test to not...

  • alexpott committed 98391f6 on 9.5.x 
    Issue #3281451 by tinto: Update Ajax FunctionalJavascript test to not...

  • alexpott committed cf48246 on 9.4.x 
    Issue #3281451 by tinto: Update Ajax FunctionalJavascript test to not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.