Problem/Motivation
There are several tests that have references to Bartik and Seven:
1 core/tests/Drupal/Tests/Core/Asset/AssetResolverTest.php
2 core/tests/Drupal/Tests/Core/Asset/CssCollectionGrouperUnitTest.php
2 core/tests/Drupal/Tests/Core/Command/GenerateThemeTest.php
3 core/tests/Drupal/Tests/Core/Extension/ExtensionDiscoveryTest.php
5 core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php
1 core/tests/Drupal/Tests/Core/Render/RendererPlaceholdersTest.php
6 core/tests/Drupal/Tests/Core/Theme/AjaxBasePageNegotiatorTest.php
These tests should be updated to either use Olivero, Claro, or System module's test_theme so we can deprecate Bartik #3249109: Deprecate Bartik and Seven #3084814: Deprecate Seven theme as mentioned at #3278124: Convert various tests that use bartik/seven to olivero/claro.
Steps to reproduce
git grep -E '(bartik)|(seven)' -- 'core/tests/Drupal/Tests/Core' | awk -F: '{print $1}' | sort | uniq -c
should return no results when this work is complete, except for \Drupal\Tests\Core\Render\RendererPlaceholdersTest
.
Remaining tasks
Update the tests.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
I don't think we need release notes or a change record.
Comment | File | Size | Author |
---|---|---|---|
#8 | core-3281449-8.patch | 7.64 KB | nod_ |
| |||
#2 | 3281449-2.patch | 7.72 KB | longwave |
Comments
Comment #2
longwaveComment #3
longwaveI used Stark or "example" where it seemed appropriate (as these will hopefully change less frequently) and Claro or Olivero otherwise.
There is one false positive in a comment in core/tests/Drupal/Tests/Core/Render/RendererPlaceholdersTest.php - this isn't referring to the theme:
Some other notes:
The test passes without this method stub so I think we can just drop it.
This test doesn't seem to be testing what it thinks it is testing, as removing this, or breaking it in a couple of different ways, didn't cause the test to fail. This probably needs investigation and a better fix elsewhere.
Comment #4
deviantintegral CreditAttribution: deviantintegral at Lullabot commentedIsn't that because the call to expects() is being removed too? That internally triggers an assertion where if the method is never called, it will fail the test at the end.
\Drupal\Tests\system\FunctionalJavascript\OffCanvasTestBase::getTestThemes
still has seven in it?On
ExtensionDiscoveryTest
, I agree that's worth filing a new issue for.Comment #5
deviantintegral CreditAttribution: deviantintegral at Lullabot commentedComment #6
daffie CreditAttribution: daffie commentedAssign this issue to the parent #3285205: [META] Convert test that use Bartik/Seven to Olivero/Claro.
Comment #7
nod_for
\Drupal\Tests\system\FunctionalJavascript\OffCanvasTestBase::getTestThemes
it's in #3281434: Update System module tests to not use Bartik and Seven that it should be handled as per the issue summary.Opened a follow-up for
ExtensionDiscoveryTest
here #3298319: Update ExtensionDiscoveryTest to not use sevenComment #8
nod_reroll
Comment #9
catchCommitted/pushed to 10.1.x and cherry-picked to 10.0.x
#8 doesn't apply to 9.5.x but #2 does, so I've just kicked off a test run against 9.5.x and will commit that to 9.5.x if it's green. If not we might need a re-roll.
Comment #11
nod_looks like it's green. Quickedit test failure seems unrelated.
Comment #12
catchYep, kicked off a retest just in case. Committed/pushed to 9.5.x, thanks!