Problem/Motivation

There are several tests that have references to Bartik and Seven:

      3 core/modules/taxonomy/tests/src/Functional/Rest/TermResourceTestBase.php
   6 core/modules/taxonomy/tests/src/Functional/ThemeTest.php

These tests should be updated to either use Olivero, Claro, or System module's test_theme so we can deprecate Bartik #3249109: Deprecate Bartik and Seven #3084814: Deprecate Seven theme as mentioned at #3278124: Convert various tests that use bartik/seven to olivero/claro.

Steps to reproduce

git grep -E '(bartik)|(seven)' -- 'core/modules/taxonomy/tests' | awk -F: '{print $1}' | sort | uniq -c should return no results when this work is complete.

Remaining tasks

Update the tests.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

I don't think we need release notes or a change record.

CommentFileSizeAuthor
#2 3281443-2.patch2.07 KB_shy

Comments

deviantintegral created an issue. See original summary.

_shy’s picture

Status: Active » Needs review
StatusFileSize
new2.07 KB

As for the TermResourceTestBase class there are no references for the Bartik and Seven themes.
Updated ThemeTest class.

deviantintegral’s picture

Status: Needs review » Reviewed & tested by the community

Excellent, but hey, at least we now know about how well llamas can count!

Patch looks good to me.

alexpott’s picture

Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed d833f15217 to 10.0.x and e68482b64e to 9.5.x and ece868286b to 9.4.x. Thanks!

Backported to 9.4.x as a test only change.

  • alexpott committed d833f15 on 10.0.x
    Issue #3281443 by _shY: Update Taxonomy tests to not use Bartik and...

  • alexpott committed e68482b on 9.5.x
    Issue #3281443 by _shY: Update Taxonomy tests to not use Bartik and...

  • alexpott committed ece8682 on 9.4.x
    Issue #3281443 by _shY: Update Taxonomy tests to not use Bartik and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.