Problem/Motivation

There are CKEditorTest references to Bartik and Seven:

7 core/modules/ckeditor/tests/src/Kernel/CKEditorTest.php

These tests should be updated to either use Olivero, Claro, or System module's test_theme so we can deprecate Bartik #3249109: Deprecate Bartik and Seven #3084814: Deprecate Seven theme as mentioned at #3278124: Convert various tests that use bartik/seven to olivero/claro.

Steps to reproduce

git grep -E '(bartik)|(seven)' -- 'core/modules/ckeditor/tests' | awk -F: '{print $1}' | sort | uniq -c should return no results when this work is complete.

Remaining tasks

Update the tests.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

I don't think we need release notes or a change record.

CommentFileSizeAuthor
#2 3281438-2-10.0.x.patch2.66 KBtinto

Comments

deviantintegral created an issue. See original summary.

tinto’s picture

tinto
Location Amsterdam
commented
Status: Active » Needs review
StatusFileSize
new 3281438-2-10.0.x.patch2.66 KB

Here's an update for core/modules/ckeditor/tests/src/Kernel/CKEditorTest.php.

The patch removes all mentions of Bartik and replaces them with Olivero. The old version checked for a number of Bartik CSS files used for CKEditor. The Olivero theme includes an entirely different set of CSS files, so the patch adds checks for all of Olivero's CSS files used for CKEditor:

  - css/base/fonts.css
  - css/base/base.css
  - css/components/embedded-media.css
  - css/components/table.css
  - css/components/text-content.css
  - css/theme/ckeditor-frame.css
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Needs review » Reviewed & tested by the community

Nice straightforward one.

  • lauriii committed 2ba2757 on 10.0.x 
    Issue #3281438 by tinto, deviantintegral, catch: Update CKEditorTest to...

  • lauriii committed 9f8fd64 on 9.5.x 
    Issue #3281438 by tinto, deviantintegral, catch: Update CKEditorTest to...

  • lauriii committed 3d860c4 on 9.4.x 
    Issue #3281438 by tinto, deviantintegral, catch: Update CKEditorTest to...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 2ba2757 and pushed to 10.0.x. Cherry-picked to 9.5.x and 9.4.x since this is a non-disruptive test change. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.