Since #3279640: Standard install profile uses Olivero for update.php is being used for update.php in standard. Unfortunately \Drupal\Tests\RequirementsPageTrait::assertRequirementSummaries() assumes that Seven is being used. This means that \Drupal\Tests\RequirementsPageTrait::updateRequirementsProblem() doesn't work because $this->assertWarningSummaries(['PHP']); fails.
Run \Drupal\Tests\standard\Functional\StandardTest using PHP 7.3 - see https://www.drupal.org/pift-ci-job/2378199.
Fix \Drupal\Tests\RequirementsPageTrait::assertRequirementSummaries() to work both with Seven and Claro.
None
None
None
N/a
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3279788-2.patch | 2.81 KB | alexpott |
Comments
Comment #2
alexpottI tested this with multiple requirement warnings by hacking in an additional requirement to system_requirements and asserting on it in \Drupal\Tests\RequirementsPageTrait::updateRequirementsProblem() as well as the expected PHP one.
Comment #3
xjm#2 works; I don't know that we can do better than that. The @todo still applies but better to fix the test suite for now.
Comment #6
larowlanCommitted to 9.5.x and cherry-picked to 9.4.x
Thanks
Comment #7
alexpottI've cherry picked this to 10.0.x because whilst it not needed there at the moment the code should be aligned and it is possible that in the future it might be needed.