Problem/Motivation

Lots of core tests have to be updated in #3219959: Update standard profile so Olivero is the default theme due to olivero_form_alter().

Instead of changing the label only in Olivero, we should do it centrally, which already has an issue: #3259931: Change default comment save button label to "Post comment" / "Reply to comment" and remove respective Olivero override.

Steps to reproduce

Proposed resolution

Remove the form alter.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3276615.patch932 bytescatch

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Title: Remove olivero_form_alter() comment button label override » Remove olivero_form_comment_form_alter() comment button label override
Status: Active » Needs review
StatusFileSize
new 3276615.patch932 bytes

Here's a patch.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

Works as expected. RTBC.

  • lauriii committed 0f903ca on 10.0.x 
    Issue #3276615 by catch, mherchel: Remove...

  • lauriii committed e0bba12 on 9.4.x 
    Issue #3276615 by catch, mherchel: Remove...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 0f903ca and pushed to 10.0.x. Also cherry-picked to 9.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.