Multiple PHP warnings during static code analysis using Phan and use of depricated function drupal_render_form [#3275954]

Problem/Motivation

PHP warnings during static code analysis using phan with messages:
"Call with 2 arg(s) to \drupal_process_form($form_id, &$form, &$form_state) which requires 3 arg(s) defined at jjbos-platform/docroot/includes/form.inc:867" in includes/common.inc

"Expected an object instance when accessing an instance property, but saw an expression $pane with type array" in panels.module

Also there is a use of depricated function drupal_render_form in in includes/common.inc

Comment	File	Size	Author
#2	panels-3275954-multiple-php-warnings.patch	1.14 KB	Dmitrii_Zadorozhnyi

Comments

Comment #1

19 April 2022 at 10:48

Dmitrii_Zadorozhnyi created an issue. See original summary.

Comment #2

Dmitrii_Zadorozhnyi commented 19 April 2022 at 10:54

Status	File	Size
new	panels-3275954-multiple-php-warnings.patch	1.14 KB

I would suggest to apply a patch.

Comment #3

liam morland

English

Ontario, CA 🇨🇦

commented 11 May 2022 at 18:43

Issue tags:

-PHP 7 PHP 8

Comment #4

joelpittet

he/him

English

Vancouver

commented 15 November 2022 at 01:58

Parent issue:

» #3157069: Plan for Panels 7.x-3.11

Adding this to the release plan #3157069: Plan for Panels 7.x-3.11

Comment #5

joelpittet

he/him

English

Vancouver

commented 16 November 2022 at 07:45

Status:

Needs review

» Needs work

Thanks for spotting that code, the code in panels_allowed_layouts::set_allowed appears to never be called.

if (!is_object($pane)) { it is always supposed to be an object, maybe it would be better to track down (via watchdog log or something) if that code is not an array and report it than to skip it?