Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.
Proposed resolution
Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3272731-3.patch | 1.23 KB | Shashwat Purav |
Comments
Comment #2
danflanagan8This one is really straightforward. There is a single test class (
Drupal\Tests\jsonapi\Functional/BlockTest) in jsonapi that mentions Classy. There are no assertions related to the markup. There just needs to be a theme to which the block plugin is assigned.In short, just do a find/replace in
Drupal\Tests\jsonapi\Functional/BlockTestthat changes 'classy' to 'stark'.I'm going to mark this as Novice to encourage participation.
Comment #3
Shashwat Purav CreditAttribution: Shashwat Purav at Portage CyberTech for Drupal Association commentedCreated a patch to change 'classy' to 'stark'.
Comment #4
danflanagan8Looks good.
Same comment as on #3272746: Layout Discovery tests should not rely on Classy though. We should save Novice issues for Novice contributors.
Comment #5
alexpottCommitted and pushed a5eec7f198 to 10.0.x and 6ee580fedc to 9.4.x and 55346fcc34 to 9.3.x. Thanks!
Backported to 9.3.x to keep tests aligned.