Closed (fixed)
Project:
Drupal core
Version:
9.4.x-dev
Component:
image.module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Mar 2022 at 20:50 UTC
Updated:
29 May 2022 at 20:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
danflanagan8Here's a patch. The ones that needed the class->stark change were
Functional/ImageStyles/ConvertTest
Functional/ImageDimensionsTest
Functional/ImageFieldDisplayTest
The rest of the changes are status message assertions I'm trying to refactor as I go through these classy issues. Hopefully they are not too distracting.
It's noteworthy that there is a Functional JS test with the following code:
First, the JsWebAssert status message methods can't count, which is what this assertion is about. Second, the assertion works because the message is added by js rather than by the theme. Probably file.js, but I'm not 100%.
Also worth calling out there's a @todo in one of the updated files that I considered handling here:
This will need to be modified after it's uncommented in order to remove the class. The problem is there are two more assertions a few lines down that are unrelated to classy/stark but fail when I uncomment them. So it's probably better to make the issue to act on the todo and not worry about it here.
Comment #3
larowlanThanks, looks good to me.
Tagging for this
Comment #5
danflanagan8failure in
Drupal\Tests\ckeditor\FunctionalJavascript\CKEditorIntegrationTest. Resetting status.Comment #6
alexpottCommitted and pushed b2c5ada364 to 10.0.x and 1c89f62b4c to 9.5.x and a07de32c7f to 9.4.x. Thanks!
I don't think this issue needs a follow-up - if anything it is #2670966: Warn users of old PHP versions - but that issue is closed.