Block tests should not rely on Classy

This is a fairly big one. But to the extent that any of these issues are exciting, this one is exciting to me. That's because it's the first one where I get to use the brand new status message assertions! #3268932: Add methods to assert status messages to WebAssert

So that's one thing you'll see here. I refactored to use those status message assertions where possible. I think only one of them NEEDED to be refactored, but the new assertions are more readable while being slightly more robust so it's an easy win.

Other changes are fairly typical of these Classy-to-Stark issues, like selecting block elements using the id instead of a class.

Something that is new to this Classy-to-Stark issue is that there were lots of selectors for block regions. In one instance I made a little map of the corresponding selectors. This is basically the mapping I used anywhere I had to make changes to selectors for regions.

+++ b/core/modules/block/tests/src/Functional/BlockTest.php
@@ -373,15 +373,22 @@ public function moveBlockToRegion(array $block, $region) {
+    $region_xpath = [
+      'header' => '//header[@role = "banner"]',
+      'sidebar_first' => '//aside[contains(@class, "layout-sidebar-first")]',
+      'content' => '//div[contains(@class, "layout-content")]',
+      'sidebar_second' => '//aside[contains(@class, "layout-sidebar-second")]',
+      'footer' => '//footer[@role = "contentinfo"]',
+    ];
+

Here's another bit of code I wanted to call out.

+++ b/core/modules/block/tests/src/Functional/BlockUiTest.php
@@ -92,8 +92,8 @@ protected function setUp(): void {
-    $this->clickLink('Demonstrate block regions (Classy)');
-    $this->assertSession()->elementExists('xpath', '//div[contains(@class, "region-highlighted")]/div[contains(@class, "block-region") and contains(text(), "Highlighted")]');
+    $this->clickLink('Demonstrate block regions (Stark)');
+    $this->assertSession()->elementExists('xpath', '//header[@role = "banner"]/div/div[contains(@class, "block-region") and contains(text(), "Header")]');

Obviously I'm changing Highlighted to Header here. But the "Highlighted" region does not appear to be special in any way. So I changed to a region that is easier to select with stark.

try that again

Updating priority to Major just like @xjm did for #3248295: Taxonomy tests should not rely on Classy and adding D10 tag.

Thanks for the review @nod_!

Here's a patch with 6.1 and 6.2 addressed. Thanks for the xpath selector in 6.2. That's pretty slick.

And thanks for 6.3. That's actually a case I included in the CR for the brand new methods for asserting status messages: https://www.drupal.org/node/3270424

I also noticed that I had removed a reference to classy in BlockDemoTest::testBlockDemo that I should not have removed. I have added it back. That is literally test coverage for classy and it needs to remain as long as classy is in core.

Of course I forgot the patch...

Oops. I guess I outsmarted myself. We do indeed need to remove classy from the list of themes in BlockDemoTest::testBlockDemo. Classy does not have a block demo page because it is marked as "hidden", thus the 404. Previously it was getting removed from the array of themes automatically since it was the default theme. So I'm re-removing classy.