Problem/Motivation

REST and JSON:API have tests of Editor module data that rely on the CKEditor module as the Editor implementation. CKEditor 4 is being removed from core, so these tests should rely on the CKEditor 5 module instead.

Proposed resolution

Use the CKEditor 5 module instead.

Release managers @catch and @xjm agreed to allow this change while CKEditor 5 is still in beta.

Remaining tasks

TBD

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3271050

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes

xjm opened merge request !2005

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review

xjm credited Wim Leers.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

This is also 100% Wim, so RTBC from me assuming tests do actually pass.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

OK, either I did something wrong, or there's something that needs to be fixed for this change to be made against HEAD currently, so this may need Wim.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review

Thanks for moving my work into this MR, @xjm!

Green, needs review 😊

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: ckeditor.module » editor.module

(And I can't review because I authored the commits 😇)

Also moving too the right component. These tests are actually owned by the Text Editor module 😅

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

Although the default is more basic than ck4 regarding the menu, which i didn't know about, the changes do look good. Module references are changed and the expected data is updated properly

Rtbc for me.

  • catch committed 579208e on 10.0.x 
    Issue #3271050 by xjm, Wim Leers, bbrala: Update REST and JSON:API...

  • catch committed 02bb7cb on 9.4.x 
    Issue #3271050 by xjm, Wim Leers, bbrala: Update REST and JSON:API...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.