Problem/Motivation

In CKEditor 4 toolbar config, when a toolbar config item is focused, screenreaders provide guidance on which arrow keys can act upon that item. For example, when focusing an available toolbar item, it says "Press the down arrow key to activate."

This is not happening in the CKEditor 5 toolbar config.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3270110

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

Issue tags: +stable blocker

bnjmnm’s picture

Status: Active » Needs review

Added this to the visually hidden label that already includes the button name. The language is largely taken from CK4, but with some differences to account for the lack of button groups and separators working differently.

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community
Parent issue: » #3238333: Roadmap to CKEditor 5 stable in Drupal 9
Related issues: +#3239423: Toolbar UI accessibility review: round 2
  • 👍 The strings used look similar to those in the CKE4 admin UI
  • 🤔Tested using https://www.drupal.org/project/devel_a11y. But that doesn't work, because this implementation does not use Drupal.announce(), unlike CKEditor 4's admin UI implementation.
  • 👍 So instead I tested this using VoiceOver. The newly added instructions were read to me.

lauriii made their first commit to this issue’s fork.

  • lauriii committed 0b783bf on 10.0.x
    Issue #3270110 by bnjmnm, Wim Leers: Toolbar config items missing "press...

  • lauriii committed 53cd5e4 on 9.4.x
    Issue #3270110 by bnjmnm, Wim Leers: Toolbar config items missing "press...

  • lauriii committed 5ebd32b on 9.3.x
    Issue #3270110 by bnjmnm, Wim Leers: Toolbar config items missing "press...
lauriii’s picture

Version: 9.4.x-dev » 9.3.x-dev
Priority: Normal » Major
Status: Reviewed & tested by the community » Fixed

Committed 0b783bf and pushed to 10.0.x. Also cherry-picked to 9.4.x and 9.3.x since CKEditor 5 is experimental. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.