The breadcrumb icon does not have sufficient contrast in high contrast mode.

CommentFileSizeAuthor
#8 chrome.png70.18 KBcindytwilliams
#8 safari.png64.61 KBcindytwilliams
#8 firefox.png90.42 KBcindytwilliams
#8 edge-after-breadcrumbs.png368.9 KBcindytwilliams
#8 edge-before-breadcrumbs.png272.51 KBcindytwilliams
#7 3269417-9.4.x-7.patch3.42 KBmherchel
#6 3269417-9.4.x-6.patch2.96 KBmherchel
#5 3269417-10.0.x-5.patch3.41 KBmherchel
#4 3269417-3.patch3.71 KBmherchel
#3 3256433-3.patch720 bytesmherchel
#2 3269417.patch3.36 KBmherchel
Windows_11__1_-2.png37.49 KBmherchel

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Version: 9.4.x-dev » 10.0.x-dev
Status: Active » Needs review
StatusFileSize
new 3269417.patch3.36 KB

This patch using css-mask to fix the issue.

Note that I also removed the RTL version of the separator icon, and instead used transform: scaleX(-1).

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3256433-3.patch720 bytes

Had to re-compile the CSS again.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3269417-3.patch3.71 KB

Attached the wrong patch! Lets try this one!

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3269417-10.0.x-5.patch3.41 KB

Here's a the same patch without the dictionary.txt additions (which were added in #3272035: Add "linktext" and "canvastext" to cspell dictionary. ).

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3269417-9.4.x-6.patch2.96 KB

9.4.x version of the same patch attached.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3269417-9.4.x-7.patch3.42 KB

Updated 9.4.x patch (I forgot to remove the unnecessary SVG)

cindytwilliams’s picture

cindytwilliams commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new edge-before-breadcrumbs.png272.51 KB
new edge-after-breadcrumbs.png368.9 KB
new firefox.png90.42 KB
new safari.png64.61 KB
new chrome.png70.18 KB

Patch #7 looks good and applies cleanly. The breadcrumbs display correctly in high-contrast mode and there are no regressions in non-high-contrast mode. Attached are screenshots in various browsers. Marking RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 3269417-9.4.x-7.patch, failed testing. View results

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs work » Reviewed & tested by the community

Unrelated failure.

  • lauriii committed a163e71 on 10.0.x 
    Issue #3269417 by mherchel, cindytwilliams: Claro: Breadcrumb divider...

  • lauriii committed 66f0b9e on 9.4.x 
    Issue #3269417 by mherchel, cindytwilliams: Claro: Breadcrumb divider...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed a163e71 and pushed to 10.0.x. Also committed the 9.4.x patch to 9.4.x. Thanks!

Not committing to 9.3.x just in case because this is removing an icon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.