Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gmarcel created an issue. See original summary.

gmarcel’s picture

Issue summary: View changes
Lukas von Blarer’s picture

I can confirm this bug with the Gin theme enable. Switching to Seven fixes the issue.

mathilde_dumond’s picture

Status: Active » Closed (duplicate)
gmarcel’s picture

Version: 8.x-1.13 » 8.x-1.15
Status: Closed (duplicate) » Active

I reopened this issue because of my comment here https://www.drupal.org/project/paragraphs/issues/2954224#comment-14678150.

Your latest patch @mathilde_dumond does not fix the problem.

Berdir’s picture

Title: Button "Add above" is missing with claro theme enabled » Button "Add above" is missing with Gin theme enabled

The issue title here is claro, in your other comment you mention gin. If gin uses yet another class, then we'll have to support that as well. Previous patches were not working correctly with nested paragraphs.

andy_w’s picture

I've amended the JS to optionally use a .layout-wrapper (if it exists - a la gin), and if not then continue to use the logic that already exists.

Status: Needs review » Needs work

The last submitted patch, 7: 3268122-add-above-button-to-work-with-gin.patch, failed testing. View results

andy_w’s picture

Fixed issue with running patch on seven

andy_w’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: 3268122-add-above-button-to-work-with-gin-8.patch, failed testing. View results

Berdir’s picture

Version: 8.x-1.15 » 8.x-1.x-dev
Status: Needs work » Needs review
FileSize
2.2 KB
1.62 KB

#3151534: "Add another item" field button is displayed as a modal action is going to break Claro again, sneaking in a fix for that as well while we touch this. Didn't test Gin, but can confirm that the patch with that still works on both Claro with and without that core patch.

mathilde_dumond’s picture

Not sure about Gin, but this works in claro. I did not remove anything, so it should also work with gin

gmarcel’s picture

I can confirm that #13 is working with Gin!

olli’s picture

Status: Needs review » Reviewed & tested by the community

#13 worked for me with latest 10.0.x core themes and gin.

ilkkave’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
FileSize
330.15 KB

This doesn't seem to work anymore with Gin 8.x-3.0-rc5. Gin seems to now have some extra wrappers around the table, causing the table and form actions not to be siblings anymore, which the patch relies on.

Gin rc4 and rc5 wrappers.

https://git.drupalcode.org/project/gin/-/commit/1a6fb153927b357466761e72... is the related commit in Gin, which causes those changes to wrappers.

ilkkave’s picture

Status: Needs work » Needs review
FileSize
2.14 KB

Here's a patch based on the previous one, that changes few of the selectors to use closest() instead of parent() to make things work with Gin 8.x-3.0-rc5. Also few minor tweaks to put results of those selectors in reusable variables.

marcoliver’s picture

Status: Needs review » Reviewed & tested by the community

The patch from #17 appears to fix the issue.

  • Berdir committed 36af17e2 on 8.x-1.x
    Issue #3268122 by andy_w, mathilde_dumond, Berdir, ilkkave: Button "Add...
Berdir’s picture

Status: Reviewed & tested by the community » Fixed

Also still works with the claro patch.

When updating existing patches with changes like this, please provide interdiffs so it's easier to review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.