Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
The "Add above" button is missing with the Claro Theme enabled.
In the previous version 1.12 i had this related issue https://www.drupal.org/project/entitygroupfield/issues/3267832. Now in the current version the button completely disappeared with claro enabled.
Comment | File | Size | Author |
---|---|---|---|
#17 | add-above-claro-gin-3268122-17.patch | 2.14 KB | ilkkave |
| |||
#16 | gin-rc4-rc5-wrappers.jpg | 330.15 KB | ilkkave |
#13 | 3268122-13-add-above-claro-gin.patch | 2.25 KB | mathilde_dumond |
| |||
#13 | 3268122-interdiff-12-13.txt | 1.62 KB | mathilde_dumond |
#12 | 3268122-add-above-button-to-work-with-gin-12-interdiff.txt | 1.62 KB | Berdir |
Comments
Comment #2
gmarcel CreditAttribution: gmarcel commentedComment #3
Lukas von BlarerI can confirm this bug with the Gin theme enable. Switching to Seven fixes the issue.
Comment #4
mathilde_dumond CreditAttribution: mathilde_dumond at MD Systems GmbH for GatherContent commentedDuplicate from #2954224: Better selector than .clearfix in "Add above"
Comment #5
gmarcel CreditAttribution: gmarcel commentedI reopened this issue because of my comment here https://www.drupal.org/project/paragraphs/issues/2954224#comment-14678150.
Your latest patch @mathilde_dumond does not fix the problem.
Comment #6
BerdirThe issue title here is claro, in your other comment you mention gin. If gin uses yet another class, then we'll have to support that as well. Previous patches were not working correctly with nested paragraphs.
Comment #7
andy_w CreditAttribution: andy_w at Numiko commentedI've amended the JS to optionally use a .layout-wrapper (if it exists - a la gin), and if not then continue to use the logic that already exists.
Comment #9
andy_w CreditAttribution: andy_w at Numiko commentedFixed issue with running patch on seven
Comment #10
andy_w CreditAttribution: andy_w at Numiko commentedComment #12
Berdir#3151534: "Add another item" field button is displayed as a modal action is going to break Claro again, sneaking in a fix for that as well while we touch this. Didn't test Gin, but can confirm that the patch with that still works on both Claro with and without that core patch.
Comment #13
mathilde_dumond CreditAttribution: mathilde_dumond at MD Systems GmbH for GatherContent commentedNot sure about Gin, but this works in claro. I did not remove anything, so it should also work with gin
Comment #14
gmarcel CreditAttribution: gmarcel commentedI can confirm that #13 is working with Gin!
Comment #15
olli CreditAttribution: olli commented#13 worked for me with latest 10.0.x core themes and gin.
Comment #16
ilkkave CreditAttribution: ilkkave at Yle - Finnish Broadcasting Company commentedThis doesn't seem to work anymore with Gin 8.x-3.0-rc5. Gin seems to now have some extra wrappers around the table, causing the table and form actions not to be siblings anymore, which the patch relies on.
https://git.drupalcode.org/project/gin/-/commit/1a6fb153927b357466761e72... is the related commit in Gin, which causes those changes to wrappers.
Comment #17
ilkkave CreditAttribution: ilkkave at Yle - Finnish Broadcasting Company commentedHere's a patch based on the previous one, that changes few of the selectors to use
closest()
instead ofparent()
to make things work with Gin 8.x-3.0-rc5. Also few minor tweaks to put results of those selectors in reusable variables.Comment #18
marcoliverThe patch from #17 appears to fix the issue.
Comment #20
BerdirAlso still works with the claro patch.
When updating existing patches with changes like this, please provide interdiffs so it's easier to review.