Problem/Motivation
We are committing lots of CKEditor 5 changes and every time we commit a change, we have to manually ensure that the files have been built correctly, using correct dependencies. This is also potential security concern, since if the committer forgets this step, it could potentially allow contributors (either accidentally or intentionally) to inject malicious code without anyone noticing.
Proposed resolution
Add step for DrupalCI that runs yarn build:ckeditor5 for the CKEditor 5 built files when they are being changed, and ensures that there aren't any changes after running the command.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3267721
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
nod_without looking too deeply into it, seems 100% related to #3238497: What to do with assets build step? and what sally proposed, that drupal ci does the compile step somehow.
Comment #3
lauriiiTotally related to that one 👍 Just noting that since we will need the build step for the lifecycle of Drupal 9 at minimum, it would still be worth while adding a step to check this regardless of what we do there.
Comment #4
nod_Comment #5
nod_ugh, bash… too young for this :p I'll get back to it next week
Comment #6
wim leersComment #8
nod_Comment #9
wim leersManually tested, works great!
Tested:
Once the nits are addressed, this is RTBC!
Comment #10
nod_updated the comments
Comment #11
wim leersComment #12
wim leersRe-confirming RTBC :)
Comment #15
lauriiiCommitted da12af1 and pushed to 10.0.x. Also cherry-picked to 9.4.x. Thanks!