Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Discovered in #3260032: CKEditor 5 adds ie11.user.warnings library to every page, triggering a FOUC even for anonymous users
When #3206686: IE11 warning for CKE5 in Drupal 9 was implemented, there were some console errors we considered acceptable, but none that obstructed page load or overall use. There have been changes since then that result in a less elegant failure
Steps to reproduce
Load a node edit page with CKEditor 5 in IE11
Proposed resolution
As I investigated solutions, I noticed that CKEditor5.es6 uses Object.entries(), and that is not something covered by our transpilation, nor is there a core polyfill for it. There would be benefits in having the solution implemented here prevented those calls to Object.entries(), as it would eliminate the need to polyfill/babel plugin code for a confirmed-incompatible browser.
Remaining tasks
Fix it
Don't apply to 10.0.x, since IE isn't supported at all.
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff_MR--7.txt | 466 bytes | bnjmnm |
| #7 | 3266310-7-d9.patch | 2.65 KB | bnjmnm |
| #7 | 3266310-7-D10.patch | 2.39 KB | bnjmnm |
| |||
| HEAD-with-node-edit.png | 693.54 KB | bnjmnm | |
Issue fork drupal-3266310
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3266310-ie11-user-warning
changes, plain diff MR !1883
1 hidden branch
Comments
Comment #3
bnjmnmLittle hacky? Maybe! On the plus side, this isn't needed for 10.0.x since IE11 is no longer supported.
Comment #4
Wim LeersI like it! :D
RTBC as soon as it's green.
This blocks #3260032: CKEditor 5 adds ie11.user.warnings library to every page, triggering a FOUC even for anonymous users.
Comment #5
longwave+1 to the killswitch idea, might also help in the other issue. RTBC assuming bot agrees.
Comment #6
lauriiiTested manually with IE 11 and reviewed the MR. Left one minor nitpick which could be fixed on commit. Could someone create a Drupal 10 patch for this?
Comment #7
bnjmnmNit fixed in the patches.
Comment #12
lauriiiCommitted 29ab012 and pushed to 10.0.x. Committed Drupal 9 patch to 9.4.x and cherry-picked to 9.3.x since CKEditor 5 is experimental. Thanks!