Problem/Motivation

In #3262573: Update our yarn dev dependencies to the extent allowed by current constraints we added acorn as a JavaScript dependency due to an issue with terser, another one of our dependencies.

A fix has already been committed to terser but no release has been made. Once https://github.com/terser/terser/issues/1143 is closed we can remove acorn again.

Steps to reproduce

Proposed resolution

Wait for a new release of terser.
Remove acorn as a dependency.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3264520-2.patch1.25 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 9.3.x-dev » 9.4.x-dev
Status: Postponed » Needs review
StatusFileSize
new 3264520-2.patch1.25 KB

If I just remove acorn and don't upgrade terser, I no longer get the error on yarn check -s anyway. But terser made a new release for us so we should upgrade to it.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

Confirmed that update is good and that it doesn't introduces changes to the compiled js files.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed ada5a430ef to 10.0.x and f4c710f847 to 9.4.x. Thanks!

  • alexpott committed ada5a43 on 10.0.x 
    Issue #3264520 by longwave: Remove acorn from package.json

  • alexpott committed f4c710f on 9.4.x 
    Issue #3264520 by longwave: Remove acorn from package.json

(cherry...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.