Problem/Motivation

#3192487: Warn about upcoming JSON database support requirement in Drupal 9 added the ::hasJson() method to the database connection class, but no test.

Proposed resolution

Add a test.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3259532

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !1687

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

mondrake’s picture

mondrake
Location 🇮🇹
commented

@murilohp please add at least one comment to this issue (not only to the MR), so your contribution can be tracked... apparently commenting on MRs only does not list people on the credits section.

murilohp’s picture

murilohp commented

Thanks for the tip @mondrake!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed c3021cf6537 to 10.0.x and 14ac9347406 to 9.4.x. Thanks!

I guess this is helpful for contrib and custom drivers that run this test... looks pretty odd tbh.

  • alexpott committed c3021cf on 10.0.x 
    Issue #3259532 by mondrake, murilohp: Add a kernel test for Connection::...

  • alexpott committed 14ac934 on 9.4.x 
    Issue #3259532 by mondrake, murilohp: Add a kernel test for Connection::...
mondrake’s picture

mondrake
Location 🇮🇹
commented

Re #7 yes, before this issue there were no tests covering this method if you had run PHPUnit with --group=Database.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake closed merge request !1687