Problem/Motivation

The files core/modules/migrate_drupal/tests/modules/migrate_state_finished_test/src/Plugin/migrate/field/FieldLeft.php and core/modules/migrate_drupal/tests/modules/migrate_state_finished_test/src/Plugin/migrate/field/FieldRight.php break PSR-2 and PSR-4 and cannot be autoloaded correctly.

Steps to reproduce

Proposed resolution

Determine if they are even needed anymore.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3258009-3.patch1.7 KBalexpott

Issue fork drupal-3258009

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

These classes broken plugin discovered because their namespaced class is \Drupal\migrate_state_active_test\Plugin\migrate\field\d7\FieldLeft and \Drupal\migrate_state_active_test\Plugin\migrate\field\d7\FieldRight but their locations are core/modules/migrate_drupal/tests/modules/migrate_state_finished_test/src/Plugin/migrate/field/FieldLeft.php and core/modules/migrate_drupal/tests/modules/migrate_state_finished_test/src/Plugin/migrate/field/FieldRight.php.

So the module name is wrong and the /d7/ is too.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Related issues: +#2936365: Migrate UI - allow modules to declare the state of their migrations
StatusFileSize
new 3258009-3.patch1.7 KB

These were added in #2936365: Migrate UI - allow modules to declare the state of their migrations but I don't think they've actually been necessary for the tests to work as expected.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

I see no usage of this broken plugins

quietone’s picture

quietone commented

Agree, these are not used. Looks like I added them when I started playing with the test but migrate field plugins aren't needed by the test. Don't know what I was thinking.

  • catch committed 69e2141 on 10.0.x 
    Issue #3258009 by alexpott: migrate_state_finished_test's FieldLeft and...

  • catch committed 0c3e9fe on 9.4.x 
    Issue #3258009 by alexpott: migrate_state_finished_test's FieldLeft and...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.3.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.