The $modules property must be declared protected in tests [#3257445]

Problem/Motivation

The $modules property must be declared protected in tests. See https://www.drupal.org/node/2909426

Proposed resolution

Declare $modules as a protected property in tests.

Remaining tasks

Write a patch
Review
Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork facets-3257445

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3257445-the-modules-property changes, plain diff MR !41
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

7 January 2022 at 15:36

idebr created an issue. See original summary.

Comment #2

idebr commented 7 January 2022 at 15:40

Issue summary:	View changes
Status:	Active	» Needs review

Comment #3

anagomes commented 7 January 2022 at 16:07

Assigned:

Unassigned

» anagomes

Comment #4

7 January 2022 at 18:06

anagomes opened merge request !41

Comment #5

anagomes commented 7 January 2022 at 18:10

Assigned:

anagomes

» Unassigned

There were some tests from submodules that still had the $modules property as public, so I changed them to protected. And also opened a MR with the two commits (mine and @idebr's).