Problem/Motivation

The media image upload widget is missing configuration schema.

Steps to reproduce

  1. Install the module
  2. Create an entity browser with a media image upload widget
  3. Install the Configuration Inspector module
  4. Visit the status reports page
  5. Confirm configuration errors are listed

Proposed resolution

Add configuration schema for the media image upload widget.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 entity_browser-missing_media_upload_image_widget_config_schema-3250751.3.patch944 bytespaweldxm
#2 entity_browser-missing_media_upload_image_widget_config_schema-3250751.2.patch946 bytesjaypan

Issue fork entity_browser-3250751

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Jaypan created an issue. See original summary.

jaypan’s picture

jaypan
Location Victoria, BC
commented
Status: Active » Needs review
StatusFileSize
new entity_browser-missing_media_upload_image_widget_config_schema-3250751.2.patch946 bytes

Attaching patch

paweldxm’s picture

paweldxm commented
StatusFileSize
new entity_browser-missing_media_upload_image_widget_config_schema-3250751.3.patch944 bytes

I had to change this replacement from boolean to string for the "multiple" variable. At this point, config_inspector no longer throws any error.

widgets.d1242488-7d4a-4c7a-b224-dbb86faf0b7a.settings.multiple Allow Multiple Files boolean Yes 1 variable type is string but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData

I've added the corrected patch.

tlo405’s picture

tlo405 commented
Status: Needs review » Reviewed & tested by the community

I ran into this same problem (my functional tests were failing locally after I added this feature to my custom entity browser). The patch in #3 fixes the issue for me.

Dave Reid made their first commit to this issue’s fork.

Dave Reid opened merge request !36

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I found a couple more things to fix and opened a MR. Working on validating and reviewing the changes.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I had to change this replacement from boolean to string for the "multiple" variable.

FYI boolean is the correct type here. Once this is committed and you update, if you re-save the entity browser configuration it should fix itself from a string to the correct boolean type for that value.

  • Dave Reid committed 9fd899d2 on 8.x-2.x 
    Issue #3250751 by Dave Reid, Jaypan, paweldxm: Fix missing and invalid...
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Tested and confirmed this resolved all config schema errors.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.