Problem/Motivation

Drupal\Tests\jsonapi\Kernel\EventSubscriber\ResourceObjectNormalizerCacherTest fails with Symfony 5, because the fix that we created in the method Drupal\Core\Validation\DrupalTranslator::trans() was not strict enough. It wrongly thinks that every validation error message with the character "|" in it is a plural message. The fix was added in #3231683: [Symfony 6] A number of methods of the class Drupal\Core\TypedData\Validation\ExecutionContext are considered internal and Drupal should not override them..

Proposed resolution

Make the fix in the method Drupal\Core\Validation\DrupalTranslator::trans() a bit stricter.

Remaining tasks

TBD

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

CommentFileSizeAuthor
#2 3248809-2.patch1.07 KBdaffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie created an issue. See original summary.

daffie’s picture

Status: Active » Needs review
FileSize
1.07 KB

The fix.

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Looks straight forward enough

  • catch committed f4d355a on 9.4.x
    Issue #3248809 by daffie, larowlan: [Symfony 6] The Drupal\Tests\file\...

  • catch committed 5939914 on 9.3.x
    Issue #3248809 by daffie, larowlan: [Symfony 6] The Drupal\Tests\file\...
catch’s picture

Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed f4d355a and pushed to 9.4.x. Thanks! Also cherry-picked to 9.3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.