Problem/Motivation
\Drupal\Tests\Component\Gettext\PoStreamWriterTest::setUp ()
causes deprecations on PHP 8.1 because of vfs issues
See #3220021-34: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves) and commit https://git.drupalcode.org/project/drupal/-/merge_requests/937/diffs?com... for credits
Steps to reproduce
Run core/tests/Drupal/Tests/Component/Gettext/PoStreamWriterTest.php
on PHP 8.1
Proposed resolution
Fix the test and wait upstream release as PHP 8.1 released https://github.com/bovigo/vfsStream/issues/252#issuecomment-836191861
Remaining tasks
review/commit
User interface changes
no
API changes
no
Data model changes
no
Release notes snippet
no
Comment | File | Size | Author |
---|---|---|---|
#2 | 3240201-2.patch | 968 bytes | andypost |
Comments
Comment #2
andypostpatch from commit
Comment #3
andyposthttps://github.com/bovigo/vfsStream/releases/tag/v1.6.10 released 6 days ago
Comment #4
andypostBut without patch still getting
I bet the fix is required because
mikey179/vfsstream
1.6.9 already contains fix https://github.com/bovigo/vfsStream/issues/252#issuecomment-881271842Comment #5
daffie CreditAttribution: daffie commentedThe
$this->poWriter->header
must be set, because calling$this->poWriter->open()
uses the value as the second parameter in the function call tofwrite()
and that must be a string value.Looks good to me.
Comment #7
catchCommitted 91f5fa9 and pushed to 9.3.x. Thanks!