When using MigrateProcessInterface->transfrom() some fields might expect something different than array or string.
Like you can pass to it a mixed value, you should be able to return a mixed value to be processed for another processor or to be added to the field.
The problem is in the comments of the method, so you can really return whatever type of value, but it makes some linting software to fail.
Edit comment so it returns a mixed value
None
Technically is an API change since it alters the definition of an interface but since just widens the options in the return is not a braking change.
None
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | drupal-3240109-2.patch | 717 bytes | quietone |
| #2 | drupal-3240109-2.patch | 717 bytes | edurenye |
Comments
Comment #2
edurenye commentedFixed
Comment #3
quietone commentedSeems I was all thumbs trying to get the correct test started.
Comment #4
martin_klimaYes, I fully agree. The MigrateProcessInterface has a wrong return type for the transform() method.
For example \Drupal\migrate\Plugin\migrate\process\MigrationLookup::transform returns NULL, so it is not compatible with the interface.
I had a problem with PHPstan check because our custom process plugin returns also NULL.
This patch works, thank you!
Comment #6
damienmckennaAs a reminder, the "assigned" field is for indicating you're actively working on something, when you're finished please set the field back to "unassigned". Thank you.
Comment #7
quietone commentedRe-uploading patch so it will test with 9.4.x.
Comment #10
catchCommitted/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!