Salesforce mapping module throws error : [error] Call to a member function id() on null [#3236726]

Problem/motivation

Salesforce mapping module throws this error.

[error] Call to a member function id() on null

Steps to reproduce

While deleting the user using entityQuery, the module throws this error.

[error] Call to a member function id() on null

Proposed solution

Add the condition to check the mapping isn't empty.

Comment	File	Size	Author
#6	salesforce-3236726-6.patch	1.41 KB	aaronbauman
#4	3236726-4.patch	1.35 KB	mayurgajar
#3	3236726-3.patch	1.35 KB	mayurgajar
#2	3236726-2.patch	1.96 KB	mohit.bansal623

Comments

Comment #1

20 September 2021 at 12:23

mayurgajar created an issue. See original summary.

Comment #2

mohit.bansal623 commented 20 September 2021 at 18:02

Assigned:	mayurgajar	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	3236726-2.patch	1.96 KB

I have assigned the value in $nid and checking the condition for not empty. Please review the patch.

Comment #3

mayurgajar commented 21 September 2021 at 05:02

Status	File	Size
new	3236726-3.patch	1.35 KB

Mapping id throws error of [error] Call to a member function id() on null
Added patch for same.

Comment #4

mayurgajar commented 21 September 2021 at 05:36

Status	File	Size
new	3236726-4.patch	1.35 KB

DO NOT USE Patch: #3 as it has minor error of condition
Added new patch for issue : Mapping id throws error of [error] Call to a member function id() on null

Comment #5

mayurgajar commented 21 September 2021 at 05:36

1 file was hidden/shown/deleted

Status	File	Size
hidden	3236726-3.patch	1.35 KB

Comment #6

aaronbauman

he/him

commented 27 September 2021 at 16:32

Version:

8.x-4.x-dev

» 5.0.x-dev

Status	File	Size
new	salesforce-3236726-6.patch	1.41 KB

What is the reason not to delete the mapped object if the mapping doesn't exist?
I think, if the mapping does not exist, we should proceed with the mapped object delete.