BOOTSTRAP_VARIABLES should be explicit [#323391]

There are no BOOTSTRAP_VARIABLE stage in the current bootstrap process. That means there is no way to explicitly know if the variable subsystem has been initialized.

I suggest we add such stage and move it just after BOOTSTRAP_DATABASE.

Comment	File	Size	Author
#6	323391-explicit-BOOTSTRAP_VARIABLE.patch	3.46 KB	Damien Tournoud
#6
#4	323391-explicit-BOOTSTRAP_VARIABLE.patch	2.94 KB	Damien Tournoud
#4
#1	323391-explicit-BOOTSTRAP_VARIABLE.patch	3.55 KB	Damien Tournoud
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Damien Tournoud CreditAttribution: Damien Tournoud commented 19 October 2008 at 19:13

Assigned:	Unassigned	» Damien Tournoud
Status:	Active	» Needs review

File	Size
323391-explicit-BOOTSTRAP_VARIABLE.patch	3.55 KB

I needed that because of #322549: t() should work regardless of the bootstrap phase.

This patch create a new BOOTSTRAP_VARIABLE stage after ACCESS but before SESSION.

Comment #2

chx CreditAttribution: chx commented 19 October 2008 at 19:29

Status:

Needs review

» Needs work

So we would allow require_once DRUPAL_ROOT . '/' . variable_get('session_inc', 'includes/session.inc'); this to come from DB. However, if you have the means to run from session.inc from somewhere else, like memcache or APC then you are advanced enough that manually editing settings.php can not be a problem.

However, if a script were to bootstrap only to SESSION then now it will run variable_init as well which (in most cases) means a database query -- before, it had the access query and the session query now it has a cache query as well. That's a very big price to pay just to not need to edit settings.php in the first case.