It is a bug report, not a feature request.
First of all: The system_mail function includes some taxonomy variables but the action settings form's description does not present these. (%term_name, %term_description, %term_id, %vocabulary_name, %vocabulary_description, %vocabulary_id) These are the hidden variables.
Next: The system_send_email_action function gives the comment's data(in the context) but doesn't use it(just the cid, to load the node). It's a bug. When I make a trigger for new comment, I can't make informative email which contains the comment data. I just make a simple message which contains node data. When anybody comments my blog I read 'You got a new comment'. This is unusable! I want to make a more informative mail that contains the comment body itself. Drupal 6 has this feature but I can't use it because the system module has this bug.
System message is the same.
Comment | File | Size | Author |
---|---|---|---|
#9 | 323325-3.patch | 1.05 KB | pp |
#8 | 323325-2.patch | 1.07 KB | pp |
#6 | comment_action_mail.zip | 958 bytes | pp |
hidden_or_missing_variables_system.module.patch | 3.86 KB | pp | |
Comments
Comment #1
Gábor HojtsySubscribe
Comment #2
Gábor HojtsyBTW this was broken off from http://drupal.org/node/287315#comment-1066369 but I am not entirely sure that it is indeed a different issue. Or at least only part of it is.
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedRight. This patch should not contain the portion of code from the feature request; it should contain only the bug fix. Remove the additional %comment* from the patch.
Comment #4
Artem CreditAttribution: Artem commentedSubscribing
Comment #5
bwooster47 CreditAttribution: bwooster47 commentedMy vote is for patching this as is. The current available action is pretty meaningless for sending emails on comments if the email cannot include any info about the subject or body of the comment. No point in having an email action at all for comments in this case.
Oh well....
Comment #6
pp CreditAttribution: pp commentedHere is a little module which resolve this problem.
Comment #7
mikeybusiness CreditAttribution: mikeybusiness commentedCan we get this patch added to 6.x? Clearly the non working variables need to be fixed.
As far as the fix containing the addition of the comment variables. I feel like they are an implementation of features already part of D6.
Comment #8
pp CreditAttribution: pp commentedHere is a patch which show hidden variables. If you like use comment data use the modul in the #6.
Comment #9
pp CreditAttribution: pp commentedOk... i thought. I suggest let's separated the two problem, hidden and missing(comment) variables.
Here is a patch for 7x and #8 for 6x. Please review.
pp
Comment #10
pp CreditAttribution: pp commentedThis issue is ambiguous. Sorry!
I created another issue. #480082: Hidden taxonomy variables in the system's send email and message action
You can find the comment's problem in #287315: Add comment variables to send email action.
Comment #11
core drupal user CreditAttribution: core drupal user commentedhidden_or_missing_variables_system.module.patch queued for re-testing.
Comment #12
mcurry CreditAttribution: mcurry commentedsubscribing
Comment #13
pp CreditAttribution: pp commentedplease read #10
Comment #14
amreesh CreditAttribution: amreesh commented#8: 323325-2.patch queued for re-testing.