Problem/Motivation

Method "Symfony\Component\Validator\Context\ExecutionContextInterface::buildViolation()" will return "ConstraintViolationBuilderInterface" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\ExecutionContext" will be required when upgrading.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3231686-2.patch1.15 KBdaffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Active » Needs review
FileSize
3231686-2.patch1.15 KB

The fix.

daffie’s picture

daffie CreditAttribution: daffie commented
Priority: Normal » Critical
Issue tags: +Drupal 10

I could not find any instances were contrib is extending the class Drupal\Core\TypedData\Validation\ExecutionContext. The adding of the return type hint does not change anything as the method already only returns what the added type hint is demanding. See: http://grep.xnddx.ru/search?text=ExecutionContext&filename=.

Part of the Symfony 6 in D10 initiative.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Looks OK to me.

  • larowlan committed f6094b0 on 9.3.x 
    Issue #3231686 by daffie: [Symfony 6] Add "...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed f6094b0 and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.