Problem/Motivation

1x: Method "Symfony\Component\DependencyInjection\ContainerBuilder::register()" will return "Definition" as of its next major version. Doing the same in child class "Drupal\Core\DependencyInjection\ContainerBuilder" will be required when upgrading.

Steps to reproduce

Proposed resolution

Add "Definition" hype hint.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3231668-2.patch642 bytesdaffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Active » Needs review
FileSize
3231668-2.patch642 bytes

The fix.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community

Lots of references to ContainerBuilder in contrib, but they all look to be instantiating or type hinting, not subclassing.

http://grep.xnddx.ru/search?text=ContainerBuilder&filename=

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Agree, no results for extends ContainerBuilder

Committed 5f608fa and pushed to 9.3.x. Thanks!

  • larowlan committed 5f608fa on 9.3.x 
    Issue #3231668 by daffie, catch: [Symfony 6] Add "Definition" type hint...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.