Problem/Motivation

This would lead to having updated theme with next parent theme version numbers in info file:

bs_versions:
  bs_bootstrap: 8005
  bs_base: 8005

The 'bs_bootstrap: 8005' version does not exist and as a consequence bs_bootstrap update 8004 will not get executed.

CommentFileSizeAuthor
#6 update-incorrect-parent-theme-version-numbers-3230320-5.patch2.38 KBpivica
#5 image-style-convert-extension-fix-from-D9-with-custom-mb-fix.patch2.77 KBpivica
#5 interdiff-3230320-3-5.txt1.77 KBpivica
#3 update-incorrect-parent-theme-version-numbers-3230320-3.patch2.18 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Title: Update generator is incorrectly updating child theme version numbers » Update generator is incorrectly updating parent theme version numbers
Issue summary: View changes
pivica’s picture

pivica commented
StatusFileSize
new update-incorrect-parent-theme-version-numbers-3230320-3.patch2.18 KB

Here is a patch which fix related generator update code and also provides update function that will check is a child theme in bad update state, fix the state and inform the user that in needs to run `drush bs-tu target-theme` one more time to correctly update custom theme.

pivica’s picture

pivica commented
Status: Active » Needs review
pivica’s picture

pivica commented
StatusFileSize
new interdiff-3230320-3-5.txt1.77 KB
new image-style-convert-extension-fix-from-D9-with-custom-mb-fix.patch2.77 KB

It seems we also need to check `bs_bootstrap: 8004` for a bad upgrade, patch updated.

pivica’s picture

pivica commented
StatusFileSize
new update-incorrect-parent-theme-version-numbers-3230320-5.patch2.38 KB

Uploaded wrong patch, here is a good one.

  • pivica committed 501e226 on 8.x-1.x 
    Issue #3230320 by pivica: Update generator is incorrectly updating...
pivica’s picture

pivica commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.