Fix run-tests.sh (for good) [#322843]

Comment	File	Size	Author
#8	322843-fix-run-tests-for-good.patch	1.06 KB	Damien Tournoud

	run-tests.php-param.patch	500 bytes	boombatower

Comment #1

boombatower CreditAttribution: boombatower commented 17 October 2008 at 22:25

Title:

Fin run-tests.sh (for testing.drupal.org)

» Fix run-tests.sh (for testing.drupal.org)

Log in or register to post comments

Comment #2

Damien Tournoud CreditAttribution: Damien Tournoud commented 17 October 2008 at 22:27

The logical order is: patch by myself, RTBC by boombatower.

This is a testing.drupal.org blocker at the moment.

Log in or register to post comments

Comment #3

boombatower CreditAttribution: boombatower commented 19 October 2008 at 00:22

Please make sure you are in contact with me when this goes in as I need to update t.d.o.
Otherwise it will get a bunch of incorrect results.

Log in or register to post comments

Comment #4

Dries CreditAttribution: Dries commented 19 October 2008 at 20:14

Status:

Reviewed & tested by the community

» Fixed

Committed to CVS HEAD. Thanks.

Log in or register to post comments

Comment #5

moshe weitzman CreditAttribution: moshe weitzman commented 28 October 2008 at 14:50

Status:

Fixed

» Active

Actually, now you have broken automatic discovery of the php path. Back to where we started.

The first condition below is now always true.


// Determine location of php command automatically, unless a comamnd line argument is supplied.
  if (isset($args['php'])) {
    $php = $args['php'];
  }
  elseif (isset($_ENV['_'])) {
    // '_' is an environment variable set by the shell. It contains the command that was executed.
    $php = $_ENV['_'];
  }

Log in or register to post comments

Comment #6

Damien Tournoud CreditAttribution: Damien Tournoud commented 28 October 2008 at 15:25

@moshe: isset() returns FALSE when an array item is set to NULL (strange, but true).

Do you have any issue with the autodetection?

Log in or register to post comments

Comment #7

moshe weitzman CreditAttribution: moshe weitzman commented 28 October 2008 at 16:10

Yes, I get this output. Clearly only the initial php script worked.

~/htd/pr$ php scripts/run-tests.sh --url http://mm/pr --verbose --color --all

Drupal test run
---------------

All tests will run.

Test run started: Tue, 10/28/2008 - 10:38

Test summary:
-------------

./scripts/run-tests.sh: line 1: ?php: No such file or directory
./scripts/run-tests.sh: line 2: //: is a directory
./scripts/run-tests.sh: line 3: /Applications: is a directory
./scripts/run-tests.sh: line 4: CHANGELOG.txt: command not found
./scripts/run-tests.sh: line 5: CHANGELOG.txt: command not found
./scripts/run-tests.sh: line 6: CVS/: is a directory
./scripts/run-tests.sh: line 8: syntax error near unexpected token `'SIMPLETEST_SCRIPT_COLOR_PASS','
./scripts/run-tests.sh: line 8: `define('SIMPLETEST_SCRIPT_COLOR_PASS', 32); // Green.'

Test run duration: 0 sec
Detailed test results:
----------------------