Closed (fixed)
Project:
Drupal core
Version:
9.2.x-dev
Component:
tour.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Jul 2021 at 10:21 UTC
Updated:
13 Aug 2021 at 05:34 UTC
Jump to comment: Most recent
Somehow, somewhere, an incorrect indentation slipped into /core/modules/tour/src/TourViewBuilder.php which now results in any change in that file being rejected by TestBot.
FILE: /var/www/html/core/modules/tour/src/TourViewBuilder.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
74 | ERROR | Comment indentation error, expected only 1 spaces
| | (Drupal.Commenting.InlineComment.SpacingBefore)
78 | ERROR | Comment indentation error, expected only 1 spaces
| | (Drupal.Commenting.InlineComment.SpacingBefore)
----------------------------------------------------------------------
This was first spotted by @quietone here and confirmed by @daffie here.
- Change something in /core/modules/tour/src/TourViewBuilder.php
- Create a patch/MR with that change
- See TestBot reject the patch in the Custom Commands phase
Attached MR should fix the indentation problems.
- Review
- Commit
- Rejoice
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
spokjeMR should fix the indentation problem.
Comment #4
longwaveRTBC if bot agrees.
Comment #5
spokjeComment #6
alexpottCommitted and pushed 38c6162c0e to 9.3.x and 2f09626f10 to 9.2.x. Thanks!
Not really sure that this is a bug fix. It doesn't result in a broken site or anything.