Problem/Motivation
When adding or editing an image effect, the page with the form doesn't give any indication of which image style this is a part of. The only way of determining this is to look at the URL, which is not good UX.
If an admin is setting up multiple image styles, this can be confusing.
Steps to reproduce
1. Go to admin/config/media/image-styles
2. Create an image style
3. Add an effect. The page title says 'Add Resize effect' (for example) but doesn't tell you which style you're working with
4. Edit the effect. The page title says 'Edit Resize effect' (for example) but doesn't tell you which style you're working with
Proposed resolution
Add the image style name to the page title e.g. 'Edit Resize effect in style STYLENAME'.
Remaining tasks
1 Discuss and approve the title wording.
2 Change the title
User interface changes
Page title changes.
API changes
Data model changes
Release notes snippet
Issue fork drupal-3223233
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
joachim commentedhttps://git.drupalcode.org/project/drupal/-/merge_requests/1216
Comment #4
longwaveCan we add a test to ensure the correct titles are displayed, and so that we don't remove them again in the future?
Comment #6
danflanagan8The tests passed including the additional coverage. Removing Needs tests tag. Ready for Review.
Comment #7
longwaveThanks for adding the test coverage. This looks good to me and is a nice usability improvement.
Comment #9
ckrinaCommitted 8a4928c and pushed to 9.4.x. Thanks!
Nice UX improvement!
Comment #10
danflanagan8Congrats on your first commit, @ckrina! 🎉
Comment #11
ckrinaThank you @danflanagan8!! :D