Problem/Motivation

When adding or editing an image effect, the page with the form doesn't give any indication of which image style this is a part of. The only way of determining this is to look at the URL, which is not good UX.

If an admin is setting up multiple image styles, this can be confusing.

Steps to reproduce

1. Go to admin/config/media/image-styles
2. Create an image style
3. Add an effect. The page title says 'Add Resize effect' (for example) but doesn't tell you which style you're working with
4. Edit the effect. The page title says 'Edit Resize effect' (for example) but doesn't tell you which style you're working with

Proposed resolution

Add the image style name to the page title e.g. 'Edit Resize effect in style STYLENAME'.

Remaining tasks

1 Discuss and approve the title wording.
2 Change the title

User interface changes

Page title changes.

API changes

Data model changes

Release notes snippet

Issue fork drupal-3223233

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

joachim created an issue. See original summary.

joachim’s picture

Title: Form to edit a single image effect doesn't tell you which style you're in » Form to edit or add a single image effect doesn't tell you which style you're in
Status: Active » Needs review

longwave’s picture

Issue tags: +Needs tests

Can we add a test to ensure the correct titles are displayed, and so that we don't remove them again in the future?

danflanagan8 made their first commit to this issue’s fork.

danflanagan8’s picture

Issue tags: -Needs tests

The tests passed including the additional coverage. Removing Needs tests tag. Ready for Review.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for adding the test coverage. This looks good to me and is a nice usability improvement.

  • ckrina committed 8a4928c on 9.4.x
    Issue #3223233 by joachim, danflanagan8, longwave: Form to edit or add a...
ckrina’s picture

Version: 9.3.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 8a4928c and pushed to 9.4.x. Thanks!

Nice UX improvement!

danflanagan8’s picture

Congrats on your first commit, @ckrina! 🎉

ckrina’s picture

Thank you @danflanagan8!! :D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.