I installed the comment_notify module on buytaert.net per http://buytaert.net/comment-notifications-via-email and found various small UI issues.



CommentFileSizeAuthor
#1 322089_ui_inconsistencies.patch6.89 KBgreggles
comment-notify-3.jpg19.58 KBDries
comment-notify-2.jpg26.43 KBDries
comment-notify-1.jpg56.42 KBDries
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Assigned: Unassigned » greggles
Status: Active » Needs review
FileSize
322089_ui_inconsistencies.patch6.89 KB

Thanks for the review, Dries. Screenshots and arrows makes it easy to know what you want fixed.

One of these was fixed in the dev version (the last extra dot) and in reviewing this myself I felt like the #description under the default state for anonymous is extraneous so I removed it. It also uses non-Drupal terminology (flag, anon).

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs review » Fixed

There was a small typo in the patch where I replaced an unnecessary . with an unnecessary ". Whoops.

I applied this to both 5.x and 6.x.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Closed (fixed) » Active

We should actually fix the perm as well as renaming it.

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/gmap/gmap_m...

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Active » Fixed

And now fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.