Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Minor clean up in date_admin. Make static analysers happy.
Steps to reproduce
None.
Proposed resolution
Checks should be a as strict as possible, reduce some complexity, unused variables and unsafe overwriting of function parameters. Address incorrect URL's to php.net.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | date-n3219052-5.patch | 13.81 KB | DamienMcKenna |
| #4 | interdiff_date-3219052-1-4.txt | 5.36 KB | steinmb |
| #4 | date-3219052-4.patch | 13.79 KB | steinmb |
| |||
| #2 | date-3219052-1.patch | 13.87 KB | steinmb |
| |||
Comments
Comment #2
steinmb CreditAttribution: steinmb as a volunteer commentedComment #3
DamienMcKennaInteresting work, thank you for taking the time to do this.
The last occurrence of "true" needs to be uppercase.
Would it be better to name the form variable $element to match hook_field_formatter_settings_form()?
Comment #4
steinmb CreditAttribution: steinmb as a volunteer commentedThank your for your swift response. Agree, naming it $element is more standard.
Comment #5
DamienMcKennaRerolled. I also simplified the link to php.net.
Comment #8
DamienMcKennaCommitted. Thanks.