Original issue

"The Easychart plugin and module was developed before Highcharts came up with their own Highcharts Editor .... Now we think it's time to give the Highcharts editor a chance..."

We need a Drupal 9 compatible version for those D9 sites that have not yet taken steps towards the Highcharts Editor.

Remaining tasks

CommentFileSizeAuthor
#10 3217949-10.patch7.87 KBTylerMarshall
#9 3217949-9.patch7.57 KBTylerMarshall

Issue fork easychart-3217949

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sharif.elshobkshy created an issue. See original summary.

sharif.elshobkshy opened merge request !1

sharif.elshobkshy’s picture

sharif.elshobkshy commented
Issue summary: View changes
Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Priority: Critical » Normal
Status: Active » Needs review
niles38’s picture

niles38 commented

Reviewed and tested. These look good to me! I converted your merge to a patch on https://www.drupal.org/project/easychart/issues/3214283 . Thank you guys!

TylerMarshall’s picture

TylerMarshall commented
Status: Needs review » Needs work

Patch no longer applies to latest 8.3-3.x branch.

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Issue summary: View changes
Parent issue: » #3214283: Status of this module?
Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Issue summary: View changes
TylerMarshall’s picture

TylerMarshall commented
Status: Needs work » Needs review
StatusFileSize
new 3217949-9.patch7.57 KB

I've updated this to fix the issues with the original patch not applying. This applies finely for me on the dev branch now.

TylerMarshall’s picture

TylerMarshall commented
StatusFileSize
new 3217949-10.patch7.87 KB

Sigh, missed the libraries. Fixed in #10.

TylerMarshall opened merge request !3

web-beest’s picture

web-beest
he/him
Primary language Dutch
commented

@TylerMarshall:
Thank you for your contribution. I have just become maintainer today so I'll need some time before I can start reviewing and applying your changes..

  • Web-Beest committed 68f085c on 8.x-3.x 
    Issue #3217949
Drupal 9 compatibility (credits @tylermarshall)
Coding...
Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented

Per #13, committed. We need a maintainer to comment here for issue credits prior to closing.

web-beest’s picture

web-beest
he/him
Primary language Dutch
commented

Fixed, thank you all for contributing.

web-beest’s picture

web-beest
he/him
Primary language Dutch
commented
Status: Needs review » Fixed

Web-Beest closed merge request !1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.