Problem/Motivation

When we remove any section or block through layout builder, the cancel button which appears on the right side of the layout builder is misaligned.

Comments

tushar_sachdeva created an issue. See original summary.

sakthivel m’s picture

Status: Active » Needs review
StatusFileSize
new816 bytes

#2 Please review the patch

mitthukumawat’s picture

StatusFileSize
new51.4 KB
new76.09 KB

@Sakthivel M I have applied the patch #2 and tested this issue manually in Claro theme. This is fixed with after this patch. Thanks for the patch.
Adding screenshots for reference. RTBC+1

manojithape’s picture

StatusFileSize
new74.62 KB
new75.1 KB

Verified and tested patch#2 on the drupal 9.3.x-dev version and Claro 9.3.0-dev version. Patch applied successfully and looks good to me.

Testing Steps:

  1. Install drupal 9.3.x-dev version.
  2. Go to Appearance -> Set Claro theme as admin and default theme
  3. Home>Administration>Structure>Content types>Article,under layout options check layout builder.
  4. Go to the article node, click on layout.
  5. Click on Add block, create a custom block>basic block.
  6. Click on -> quick edit -> "Remove Block" option
  7. Observe on confirming remove "Cancel" button not displayed center aligned.
  8. Now apply the patch and clear the cache.
  9. Again Go to the article node, click on layout.
  10. Click on Add block, create a custom block>basic block.
  11. Click on -> quick edit -> "Remove Block" option
  12. Verify "Cancel" option displayed center aligned.

Testing Results:

After applying the patch "Cancel" option displayed center aligned.
Please refer attached Before patch screenshot and After patch screenshot images for reference.

Moving this ticket to RTBC.

manojithape’s picture

Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3214170.2.patch, failed testing. View results

imalabya’s picture

Status: Needs work » Reviewed & tested by the community

Seems unrelated test failure. Moving to RTBC

alexpott’s picture

Component: Claro theme » layout_builder.module
Status: Reviewed & tested by the community » Needs work

I think this should be fixed in layout builder and I think we should consider the example set by the confirm form and make the cancel link look like a button.

alexpott’s picture

Status: Needs work » Reviewed & tested by the community

So with bartik the cancel button is already center aligned. And at least this is only changing the off canvas css so perhaps this is okay. Discussed with @lauriii - both of us feel that it'd be great if themes didn't need to be concerned with stuff like this but the reality is that it's just not possible. I'll commit once the alpha freeze is over.

alexpott’s picture

Component: layout_builder.module » Claro theme
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed f4ff1b59da to 9.4.x and 3d8ead3c02 to 9.3.x. Thanks!

Backported to 9.3.x as Claro is not stable yet but might be in 9.3.0.

  • alexpott committed f4ff1b5 on 9.4.x
    Issue #3214170 by Sakthivel M, manojithape, mitthukumawat,...

  • alexpott committed 3d8ead3 on 9.3.x
    Issue #3214170 by Sakthivel M, manojithape, mitthukumawat,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.