Closed (fixed)
Project:
Drupal core
Version:
9.3.x-dev
Component:
Claro theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 May 2021 at 17:24 UTC
Updated:
12 Nov 2021 at 18:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sakthivel m commented#2 Please review the patch
Comment #3
mitthukumawat commented@Sakthivel M I have applied the patch #2 and tested this issue manually in Claro theme. This is fixed with after this patch. Thanks for the patch.
Adding screenshots for reference. RTBC+1
Comment #4
manojithape commentedVerified and tested patch#2 on the drupal 9.3.x-dev version and Claro 9.3.0-dev version. Patch applied successfully and looks good to me.
Testing Steps:
Testing Results:
After applying the patch "Cancel" option displayed center aligned.
Please refer attached Before patch screenshot and After patch screenshot images for reference.
Moving this ticket to RTBC.
Comment #5
manojithape commentedComment #7
imalabyaSeems unrelated test failure. Moving to RTBC
Comment #8
alexpottI think this should be fixed in layout builder and I think we should consider the example set by the confirm form and make the cancel link look like a button.
Comment #9
alexpottSo with bartik the cancel button is already center aligned. And at least this is only changing the off canvas css so perhaps this is okay. Discussed with @lauriii - both of us feel that it'd be great if themes didn't need to be concerned with stuff like this but the reality is that it's just not possible. I'll commit once the alpha freeze is over.
Comment #10
alexpottComment #11
alexpottCommitted and pushed f4ff1b59da to 9.4.x and 3d8ead3c02 to 9.3.x. Thanks!
Backported to 9.3.x as Claro is not stable yet but might be in 9.3.0.