Early bootstrap queries generate notices when query logging is enabled

The original code was:

$name = $user->uid ? $user->name : variable_get('anonymous', 'Anonymous');

Generally global $user exists, except there are perhaps 2 queires during bootstrap before $user is properly instantiated - the first in http://api.drupal.org/api/function/drupal_is_denied/6 and the 2nd (the one used to create $user) in http://api.drupal.org/api/function/sess_read/6.

I'm not sure that these queries should really be attributed to the anon user? But what else to use?

Actually it is probably worth having a look at/play with devel.module which is what the query logging functionality was originally aimed at.

It should probably be something like the following:

$name = isset($user) && isset($user->uid) ? ($user->uid ? $user->name : variable_get('anonymous', 'Anonymous')) : 'User not loaded';

But that seems...kinda convoluted.

I don't believe this bug magically disappeared.

And clarifying the title.

Closed. The reason: expired.

How is "expired" a reason to close this issue?

I still have this issue, and actually just filed a separate bug report, which I've now mark as a duplicate of this one:

#2623902: dev_query broken with early db queries

Found yet another dupe:

#367274: Trying to get property of non-object in [www]\includes\database.mysqli.inc on line 102

Aaaaand another one, that actually has a patch.

#351844: Early mysql queries generate notices when query logging is enabled

FWIW, the patch there is a simplified version of what Dave Reid suggested in comment #3 above.

I think we should close this issue, even though it has more followers and comments from respected community members, because #351844 already has a patch, while this one does not. This is so that the person who worked on that patch would get credit were it ever to get committed.