Problem/Motivation

To enable different theming or facet customizations it should be possible to keep a parent active if a child gets selected in a hierarchy facet. This optional behavior should not influence the search result.

Steps to reproduce

Proposed resolution

Add a keep_hierarchy_parents_active settings option.

Remaining tasks

User interface changes

A new checkox in the facet edit form.

API changes

Getter and setter in FacetInterface.

Data model changes

New field in schema.

Issue fork facets-3204072

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mkalkbrenner created an issue. See original summary.

mkalkbrenner opened merge request !14

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Active » Needs work

This looks great, I'd love to have test-coverage for this as well. I'm not sure if we need to make an upgrade path or default value for the config change?

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at Jarltech Europe GmbH commented
Issue tags: +Needs tests

I don't think that an upgrade path is required as the default value is FALSE.
I add tests if there's acceptance ;-)

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at Jarltech Europe GmbH commented
Status: Needs work » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Ok, looks great.

  • borisson_ committed f287133 on 8.x-1.x authored by mkalkbrenner 
    Issue #3204072 by mkalkbrenner: Optionally keep parents active if child...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented

Merged through the gitlab UI, thank you very much @mkalkbrenner!

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at Jarltech Europe GmbH commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.