Problem/Motivation

We are so excited to share something all the Ukrainians are proud of – our national cuisine superstar Borscht!

One of the best Ukrainian chefs Yevhen Klopotenko gave us his exclusive recipe for this delicious soup. Even though it can be cooked in so many ways, Yevhen’s Borscht with pork ribs represents classical gastro culture and overall cooking tradition of Ukraine.

We believe that Drupal Ukraine community will praise the initiative and we will celebrate a new stage of Borscht popularization together!

Proposed resolution

Let's do it!

Remaining tasks

Review, commit, enjoy 😋

The merge request includes:

  • New recipe content (English) and Spanish translation;
  • Optimized image with empty JPG metadata;

The screenshot of the new page is taken after installing Umami with applied merge request:

Screenshot of the new recipe

CommentFileSizeAuthor
#4 borscht_screen.png662.64 KBsnig

Issue fork drupal-3203604

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

snig created an issue. See original summary.

snig’s picture

snig’s picture

Issue summary: View changes
FileSize
662.64 KB
snig’s picture

Issue summary: View changes
snig’s picture

Issue summary: View changes
Matroskeen’s picture

Issue summary: View changes

Looks great! Adding just some minor tidy-up

Matroskeen’s picture

Issue summary: View changes
Matroskeen’s picture

snig’s picture

Assigned: snig » Unassigned
Status: Active » Needs review
Matroskeen’s picture

Issue summary: View changes
snig’s picture

Issue summary: View changes
shaal’s picture

This recipe looks great (and yummy!)
Thank you for creating this.

I found only a few very small things that should get fixed:

There are some mistakes in the English version, for example:
In step 3, Take the carrot and it into medium pieces. - is missing a verb.
or
The heart of the borscht are pre-roasted vegetables., the word are should be replaced with the word is
(there are more, but I wish someone else would be able to review those)

Spanish - we should find someone that can review text in Spanish.

In ingredients:
g, l, ml should not have a space before, and should be attached to the number.
You can check the Vegan chocolate and nut brownies recipe to see how it's done there.

Thanks again, I cannot wait to make it!

shaal’s picture

Status: Needs review » Needs work

kuldeep_mehra27 made their first commit to this issue’s fork.

Eli-T made their first commit to this issue’s fork.

Eli-T’s picture

This is quite far from the English writing style for Umami so I've tried to get it closer. Note the writing styles for Umami are in https://www.drupal.org/project/drupal/issues/2940146 (English) and https://www.drupal.org/project/drupal/issues/3011647 (Spanish)

I can't comment on the Spanish unfortunately!

Couple of remaining questions

  1. Is this really an accompaniment rather than a main course, snack, or starter? IE something you'd have on the side of a main dish like a salad? Fair play if that's how you roll in Ukraine, but thought I'd ask
  2. The recipe says
    The heart of the borscht is pre-roasted vegetables.

    but doesn't actually roast any vegetables. What am I missing?

diarcastro’s picture

I just put some comments in the Merge Request in order to have the Spanish translation neutral.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

snig’s picture

@Eli-T

but doesn't actually roast any vegetables.

Could you provide examples, please?

Let me explain.
This is the stage when all the vegetables should be roasted on a saucepan first (before putting vegetables in a pot):

Place the butter in a saucepan and add the vegetables. Cook them over a moderate heat until soft.

That is what the secret of this recipe is about: one can put raw vegetables in a pan directly. Yet if you pre-roast them in a saucepan first, borscht will be better.

Changes related to translations was added.

snig’s picture

Status: Needs work » Needs review
Eli-T’s picture

Status: Needs review » Needs work

@snig thank you so much for all your work on this!

I queried the use of the word roast because in English that specifically means to cook in an oven (or sometimes to spit roast over an open fire). In this recipe for borscht you are cooking the vegetables in a pan over a hob before adding them to the stew; more correct terms for that process would be fry or sauté.

justafish made their first commit to this issue’s fork.

justafish’s picture

Issue tags: +ddd2022
Eli-T’s picture

Status: Needs work » Needs review

I can't see anything more blocking this being added; however I've done too much on this to now RTBC. Reviews welcome!

snig’s picture

Great work @Eli-T and justafish!

Finn Lewis’s picture

I've tested the install, read the recipe through and it sounds great!

A couple of minor suggestions.

In point 6, it reads:

Optionally add canned beans.

Suggest adding a 'the':

Optionally add the canned beans.

In point 7, English, it reads:

Put smoked pears in the pot. They will make your dish smell smoky.

I'd suggest changing this to:

Add the smoked pears to the pot. They will make your dish smell smoky.

The only other thing is that it mentions optional canned beans in the instructions, but they are not listed in the ingredients.

Suggest adding the following to the list of ingredients:

Canned beans (optional)

ckrina made their first commit to this issue’s fork.

ckrina’s picture

I've just changed the recipe in Spanish to use the imperative mood and active voice as defined in https://www.drupal.org/project/drupal/issues/3011647

Finn Lewis’s picture

Thanks Eli, looks good to me. Happy to mark RTBC if the tests pass.

dawehner’s picture

I tried to review the new recipe. While reading the recipe I realized that the instructions talk about sour cream and dill for serving, but the ingredients itself don't list them.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

I've given this another read, this looks sane for me.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 599011559b to 10.0.x and c6bda0477d to 9.4.x and 409d23cd0b to 9.3.x. Thanks!

Discussed with @lauriii and @Gábor Hojtsy and we all agreed to put this recipe into Umami.

  • alexpott committed 5990115 on 10.0.x
    Issue #3203604 by Eli-T, snig, justafish, kuldeep_mehra27, Matroskeen,...

  • alexpott committed c6bda04 on 9.4.x
    Issue #3203604 by Eli-T, snig, justafish, kuldeep_mehra27, Matroskeen,...

  • alexpott committed 409d23c on 9.3.x
    Issue #3203604 by Eli-T, snig, justafish, kuldeep_mehra27, Matroskeen,...
bardiuk’s picture

🎉

xjm’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.