Problem/Motivation
We are so excited to share something all the Ukrainians are proud of – our national cuisine superstar Borscht!
One of the best Ukrainian chefs Yevhen Klopotenko gave us his exclusive recipe for this delicious soup. Even though it can be cooked in so many ways, Yevhen’s Borscht with pork ribs represents classical gastro culture and overall cooking tradition of Ukraine.
We believe that Drupal Ukraine community will praise the initiative and we will celebrate a new stage of Borscht popularization together!
Proposed resolution
Let's do it!
Remaining tasks
Review, commit, enjoy 😋
The merge request includes:
- New recipe content (English) and Spanish translation;
- Optimized image with empty JPG metadata;
The screenshot of the new page is taken after installing Umami with applied merge request:
Comment | File | Size | Author |
---|
Issue fork drupal-3203604
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
snig CreditAttribution: snig as a volunteer and at DevBranch, Drupal Ukraine Community for DevBranch commentedComment #4
snig CreditAttribution: snig as a volunteer and at DevBranch, Drupal Ukraine Community for DevBranch commentedComment #5
snig CreditAttribution: snig as a volunteer and at DevBranch, Drupal Ukraine Community for DevBranch commentedComment #6
snig CreditAttribution: snig as a volunteer and at DevBranch, Drupal Ukraine Community for DevBranch commentedComment #7
MatroskeenLooks great! Adding just some minor tidy-up
Comment #8
MatroskeenComment #9
MatroskeenComment #10
snig CreditAttribution: snig as a volunteer and at DevBranch, Drupal Ukraine Community for DevBranch commentedComment #11
MatroskeenComment #12
snig CreditAttribution: snig as a volunteer and at DevBranch, Drupal Ukraine Community for DevBranch commentedComment #13
shaalThis recipe looks great (and yummy!)
Thank you for creating this.
I found only a few very small things that should get fixed:
There are some mistakes in the English version, for example:
In step 3,
Take the carrot and it into medium pieces.
- is missing a verb.or
The heart of the borscht are pre-roasted vegetables.
, the wordare
should be replaced with the wordis
(there are more, but I wish someone else would be able to review those)
Spanish - we should find someone that can review text in Spanish.
In ingredients:
g
,l
,ml
should not have a space before, and should be attached to the number.You can check the
Vegan chocolate and nut brownies
recipe to see how it's done there.Thanks again, I cannot wait to make it!
Comment #14
shaalComment #17
Eli-TThis is quite far from the English writing style for Umami so I've tried to get it closer. Note the writing styles for Umami are in https://www.drupal.org/project/drupal/issues/2940146 (English) and https://www.drupal.org/project/drupal/issues/3011647 (Spanish)
I can't comment on the Spanish unfortunately!
Couple of remaining questions
but doesn't actually roast any vegetables. What am I missing?
Comment #18
diarcastro CreditAttribution: diarcastro as a volunteer and at Evolving Web commentedI just put some comments in the Merge Request in order to have the Spanish translation neutral.
Comment #21
snig CreditAttribution: snig as a volunteer and at DevBranch, Drupal Ukraine Community for DevBranch commented@Eli-T
Could you provide examples, please?
Let me explain.
This is the stage when all the vegetables should be roasted on a saucepan first (before putting vegetables in a pot):
That is what the secret of this recipe is about: one can put raw vegetables in a pan directly. Yet if you pre-roast them in a saucepan first, borscht will be better.
Changes related to translations was added.
Comment #22
snig CreditAttribution: snig as a volunteer and at DevBranch, Drupal Ukraine Community for DevBranch commentedComment #23
Eli-T@snig thank you so much for all your work on this!
I queried the use of the word roast because in English that specifically means to cook in an oven (or sometimes to spit roast over an open fire). In this recipe for borscht you are cooking the vegetables in a pan over a hob before adding them to the stew; more correct terms for that process would be fry or sauté.
Comment #25
justafishComment #26
Eli-TI can't see anything more blocking this being added; however I've done too much on this to now RTBC. Reviews welcome!
Comment #27
snig CreditAttribution: snig as a volunteer and at DevBranch, Drupal Ukraine Community for DevBranch commentedGreat work @Eli-T and justafish!
Comment #28
Finn Lewis CreditAttribution: Finn Lewis as a volunteer and at Agile Collective, LocalGov Drupal commentedI've tested the install, read the recipe through and it sounds great!
A couple of minor suggestions.
In point 6, it reads:
Optionally add canned beans.
Suggest adding a 'the':
Optionally add the canned beans.
In point 7, English, it reads:
Put smoked pears in the pot. They will make your dish smell smoky.
I'd suggest changing this to:
Add the smoked pears to the pot. They will make your dish smell smoky.
The only other thing is that it mentions optional canned beans in the instructions, but they are not listed in the ingredients.
Suggest adding the following to the list of ingredients:
Canned beans (optional)
Comment #30
ckrinaI've just changed the recipe in Spanish to use the imperative mood and active voice as defined in https://www.drupal.org/project/drupal/issues/3011647
Comment #31
Finn Lewis CreditAttribution: Finn Lewis as a volunteer and at Agile Collective, LocalGov Drupal commentedThanks Eli, looks good to me. Happy to mark RTBC if the tests pass.
Comment #32
dawehnerI tried to review the new recipe. While reading the recipe I realized that the instructions talk about sour cream and dill for serving, but the ingredients itself don't list them.
Comment #33
dawehnerI've given this another read, this looks sane for me.
Comment #34
alexpottCommitted and pushed 599011559b to 10.0.x and c6bda0477d to 9.4.x and 409d23cd0b to 9.3.x. Thanks!
Discussed with @lauriii and @Gábor Hojtsy and we all agreed to put this recipe into Umami.
Comment #38
bardiuk CreditAttribution: bardiuk commented🎉
Comment #39
xjm