Motivation

It is currently very hard (impossible) to hook into the process of instantiating Mailchimp library objects.

Proposed resolution

Introduce a mailchimp client factory service.

User interface changes

None

API changes

None (yet)

CommentFileSizeAuthor
#2 3195197-2.patch5.19 KBcasey

Issue fork mailchimp-3195197

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

casey created an issue. See original summary.

casey’s picture

casey CreditAttribution: casey at SWIS commented
Status: Active » Needs review
FileSize
3195197-2.patch5.19 KB

gcb made their first commit to this issue’s fork.

gcb opened merge request !17

gcb’s picture

gcb
he/him
CreditAttribution: gcb as a volunteer and at ThinkShout for Mailchimp commented
Assigned: Unassigned » gcb

This is great, thanks @casey! I reviewed the code and added more explicit commenting, also verifying I understood what was happening. Please let me know if I misunderstood anything.

gcb’s picture

gcb
he/him
CreditAttribution: gcb as a volunteer and at ThinkShout for Mailchimp commented
Status: Needs review » Reviewed & tested by the community

  • gcb committed 4f2631d on 2.x 
    Issue #3195197: comments and code style for factory service.
  • gcb committed 7397269 on 2.x authored by casey
    Issue #3195197 by casey: Use a factory service to create Mailchimp...
gcb’s picture

gcb
he/him
CreditAttribution: gcb as a volunteer and at ThinkShout for Mailchimp commented
Status: Reviewed & tested by the community » Fixed

  • spncr committed daab9d8 on 2.x authored by bbrala 
    Issue #3197461 by bbrala: Fix in issue #3195197 makes the modules php7.4...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.