Problem/Motivation

Block layout overflow issue and Incorrect style for all draggable table on mobile.

Steps to reproduce

1. login as admin
2. use claro or olivero (issue in both)
3. goto => structure => block layout
4. switch to mobile device you will see contents are overflowing outside page from right.

Proposed resolution

the fix is to add overflow scroll to table wrapper

Remaining tasks

Need review and test

User interface changes

scroll added for table and align for text and buttons are also fixed

Release notes snippet

Drupal version 11

CommentFileSizeAuthor
#36 after-mr-360-width.jpg88.99 KBshivam_tiwari
#36 before-mr-360-width.jpg98.29 KBshivam_tiwari
#36 after-mr-280-width.jpg88.55 KBshivam_tiwari
#36 before-mr-280-width.jpg89.65 KBshivam_tiwari
#35 Screencast from 2025-03-24 11-25-39.gif753.58 KBsandip
#30 beforeGalaxyS8.png24.64 KBasawari
#29 AfteriPhone14ProMax.png33.66 KBasawari
#29 AfteriPhone12Pro.png32.54 KBasawari
#29 AfterGalaxyS8.png34.1 KBasawari
#29 BeforeiPhone14ProMax.png28.23 KBasawari
#29 BeforeiPhone12Pro.png28.23 KBasawari
#29 beforeGalaxyS8.png24.64 KBasawari
#24 Screenshot 2024-12-09 at 10.42.37 PM.png202.16 KBsaurav-drupal-dev
#24 Screenshot 2024-12-09 at 10.43.00 PM.png170.11 KBsaurav-drupal-dev
#22 Olivero-issue-fixed-after-mr.png155.64 KBdjsagar
#22 Claro-issue-after-mr.png135.8 KBdjsagar
#22 Olivero-issue.png164.76 KBdjsagar
#22 Claro-issue.png151.5 KBdjsagar
#16 Screenshot 2024-10-17 at 1.29.03 PM.png64.1 KBsaurav-drupal-dev
#16 Screenshot 2024-10-17 at 11.34.54 AM.png60.03 KBsaurav-drupal-dev
#16 Screenshot 2024-10-17 at 11.33.00 AM.png40.33 KBsaurav-drupal-dev
#16 Screenshot 2024-10-17 at 1.18.11 PM.png57.61 KBsaurav-drupal-dev
#16 Screenshot 2024-10-17 at 1.17.54 PM.png65.45 KBsaurav-drupal-dev
#6 20210123_045253184.mp420.36 MBdjsagar
#6 Screen Shot 2021-01-23 at 4.54.09 AM.png84.32 KBdjsagar
#4 3193332-after4.png40.03 KBabhijith s
#4 3193332-after3.png46.92 KBabhijith s
#4 3193332-after2.png51.73 KBabhijith s
#4 3193332-aftee1.png47.84 KBabhijith s
#4 3193332-before_4.png39.59 KBabhijith s
#4 3193332-before_3.png54.63 KBabhijith s
#4 3193332-before_2.png52.86 KBabhijith s
#4 3193332-before_1.png50.63 KBabhijith s
#3 3193332-3.patch1.13 KBdjsagar
#3 Screen Shot 2021-01-18 at 6.59.21 PM.png91.65 KBdjsagar
#2 Screen Shot 2021-01-18 at 6.41.04 PM.png91.1 KBdjsagar

Issue fork drupal-3193332

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

djsagar created an issue. See original summary.

djsagar’s picture

StatusFileSize
new91.1 KB
djsagar’s picture

Status: Active » Needs review
StatusFileSize
new91.65 KB
new1.13 KB

I create patch to relative this issue please review and give feedback.

Thanks!

abhijith s’s picture

StatusFileSize
new50.63 KB
new52.86 KB
new54.63 KB
new39.59 KB
new47.84 KB
new51.73 KB
new46.92 KB
new40.03 KB

Applied patch #3.Adding screenshots below.

Before patch:

before

before2

after3

before4

After patch:

after

after2

after3

after4

In the last image you can see that the issue is still there.It works well in other cases.Still needs work.

abhijith s’s picture

Status: Needs review » Needs work
djsagar’s picture

Status: Needs work » Needs review
StatusFileSize
new84.32 KB
new20.36 MB

Well for 320px of mobile i upload video after applied patch and not able to replicate 320px mobile issue please watch video.

Still you found the issue try Caches cleared then check.

Thanks!
.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests, +Needs work

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Think this will need to be updated for D10 themes as bartik and seven have been removed.
Tagging for tests to show the issue.
Believe this still could be issue.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

akashdab’s picture

Issue tags: -

This issue still persists in both Claro and Olivero themes.

While in both of them the layout content overflows, in my testing it is much worse with olivero; it makes the overflowing content illegible with the layout content not taking on white background color like it does in claro.

Link to test with Claro.
Link to test with Olivero.

saurav-drupal-dev made their first commit to this issue’s fork.

saurav-drupal-dev’s picture

I have created MR with the fix for both themes please review.

Before
before
before

After
after
after

smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs issue summary update
saurav-drupal-dev’s picture

Issue summary: View changes
saurav-drupal-dev’s picture

Status: Needs work » Needs review
saurav-drupal-dev’s picture

Issue summary: View changes
smustgrave’s picture

Status: Needs review » Needs work
Issue tags: -Needs tests, -Needs issue summary update +Needs screenshots

UI changes should be included in an issue summary. Adding a sentence doesn't count. Before/after screenshots should be added

djsagar’s picture

StatusFileSize
new151.5 KB
new164.76 KB
new135.8 KB
new155.64 KB

I have checked MR #15 in Drupal 11.
It fixed the Olivero issue on mobile, but the issue still persists in Claro.

Olivero
Before MR
Olivero issue

After MR
Olivero issue fixed after mr

Claro
Before MR
Claro issue

After MR
Claro issue after mr

djsagar’s picture

Issue tags: -Needs screenshots

Removed the tag and added a screenshot, but the issue still persists.

saurav-drupal-dev’s picture

i have fixed the issue mentioned @djsagar

before
before

after
after

saurav-drupal-dev’s picture

Status: Needs work » Needs review
smustgrave’s picture

asawari’s picture

StatusFileSize
new24.64 KB
new28.23 KB
new28.23 KB
new34.1 KB
new32.54 KB
new33.66 KB

Test status - Pass
Verified an issue on Drupal 11.X version for Olivero and claro themes. MR applied successfully. Issue looks fixed.

Followed steps below-
1. login as admin
2. use claro or olivero
3. goto => structure => block layout
4. switch to mobile device you will see contents are overflowing outside page from right.

Attaching screenshots for reference.

RTBC+1

asawari’s picture

StatusFileSize
new24.64 KB
saschaeggi’s picture

We have scrollable tables with scroll indicators in Gin

So we might want to consider re-using Gin’s implementation here also to avoid potential conflicts and issues

smustgrave’s picture

Status: Needs review » Needs work

Should investigate #31since it came from a claro maintainer

sandip’s picture

I am working here to implement Gin's process as mentioned in #31.

sandip’s picture

Another thing i want to ask that changes should be done for only Claro theme right? it does not make any sense to implement the same for Olivero as it is not a admin theme. Please correct me if i am wrong.

sandip’s picture

Status: Needs work » Needs review
StatusFileSize
new753.58 KB

Hi @saschaeggi, @smustgrave,

I have worked on fixing the issue and add some change to table.html.twig file as i applied a parent div to the table so i can apply overflow-x: auto to it as same as Gin. This issue is not only for Block layout page this issue will occur everywhere where table twig file is rendering so i had to change the table.html.twig file. As i see i also need to change the view-view-table.html.twig also as the same issue is coming from it. So should i change the views table twig file in this issue queue?

In the current MR, I haven't applied the changes for the Olivero theme. Please let me know if you would like me to include those adjustments as well.

Thank you!

shivam_tiwari’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new89.65 KB
new88.55 KB
new98.29 KB
new88.99 KB

I checked this issue and MR. Faced same problem on Drupal fresh set up. After applying MR as a patch it resolves problem. Moving this issue to RTBC as it looks fine.
Adding some screenshots related to my testing.

shivam_tiwari’s picture

Status: Reviewed & tested by the community » Needs review

Ohh, Current MR is not applied for Olivero theme. Moving this to Needs Review.
@saschaeggi, @smustgrave, Please check and provide your feedback.

sandip’s picture

https://www.drupal.org/project/drupal/issues/3068696 I found this issue which is already working for fixing the table responsive issue for claro theme. I think we can close or Duplicate this issue. @smustgrave, can you please look into it.

smustgrave’s picture

Status: Needs review » Closed (duplicate)

Agree that issue seems like this was a duplicate.