display name not saving [#3189269]

Problem/Motivation

The display name setting on the quiz settings page doesn't save.

Steps to reproduce

1. navigate to admin/quiz/config/quiz
2. enter a different text into the display name setting text box, ie "Assessment"
3. click the "Save configuration" button

Proposed resolution

The setting should save and the new word(s) should show in the front end

Not sure if this is supposed to work yet or not, but I didn't see an existing issue for yet.

Comment	File	Size	Author
#4	display_name_not_saving_3189269_2.patch	812 bytes	jacobbell84
#3	display_name_not_saving_3189269_1.patch	776 bytes	happy047

Comments

Comment #1

20 December 2020 at 19:01

WorldFallz created an issue. See original summary.

Comment #2

WorldFallz commented 20 December 2020 at 19:02

Issue summary:

View changes

Comment #3

happy047 commented 25 June 2021 at 11:16

Status:

Active

» Needs review

Status	File	Size
new	display_name_not_saving_3189269_1.patch	776 bytes

I got the same issue. After saving, the updated name was not displaying. Created a patch for the issue

Comment #4

jacobbell84 commented 19 January 2022 at 23:59

Status	File	Size
new	display_name_not_saving_3189269_2.patch	812 bytes

Doing a reroll for the latest release

Comment #5

djdevin

he/him

English

Philadelphia

commented 26 January 2022 at 17:16

This doesn't make sense, it creates a configuration key called (literal) '\Drupal\quiz\Util\QuizUtil::getQuizName()'

# drush cget quiz.settings
revisioning: false
durod: true
[..]
override_admin_feedback: 0
'\Drupal\quiz\Util\QuizUtil::getQuizName()': test123

Comment #6

djdevin

he/him

English

Philadelphia

commented 26 January 2022 at 17:37

I think we should actually deprecate this functionality.

Entities in D8 have multiple ways of representing the title, for example as singular, plural, and in lists.

 *   label = @Translation("Quiz"),
 *   label_collection = @Translation("Quiz"),
 *   label_singular = @Translation("quiz"),
 *   label_plural = @Translation("quizzes"),
 *   label_count = @PluralTranslation(
 *     singular = "@count quiz",
 *     plural = "@count quizzes",
 *   ),
 *   bundle_label = @Translation("Quiz type"),

So if you put in "Assessment" we'd have to assume that the plural was "Assessmentes" which is incorrect.

Unlike Drupal 7 in D8+ we have Quiz types so you can specify a label per bundle (visit admin/quiz/quiz-types/manage/quiz) so maybe we should use that instead of a configuration item.