Problem/Motivation
We need to add PHP 8 stuff to .htaccess files because there is php7 stuff.
Proposed resolution
Add checks for mod_php.c - PHP has changed the module name so we don't have to do this in the future. Yay. See https://www.php.net/manual/en/migration80.other-changes.php - php7_module has been renamed to php_module.
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
The root .htaccess file now has a section for PHP 8 settings. This brings .htaccess files into alignment with Drupal's supported PHP version.
If you have a custom .htaccess file and its PHP settings are working, you can keep using your existing .htaccess file unchanged. If you are upgrading from PHP 7 to PHP 8, you should copy the custom settings that you need from the PHP 7 section to the PHP 8 section.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | interdiff.3186524.2-8.txt | 427 bytes | longwave |
| #8 | 3186524-8.patch | 1.82 KB | longwave |
Comments
Comment #2
alexpottHere's a patch. We did this late for PHP 7 too... see #2455465: Add mod_php7 check to htaccess and remove php5 code
Comment #3
alexpottComment #4
gábor hojtsyLooks good.
Comment #6
xjm.htaccesschanges are an "always release note" category. (What we have is a bit thin I think.)Comment #7
xjmSee https://www.drupal.org/project/drupal/releases/9.1.0#htaccess for an example of the language to use.
Comment #8
longwaveFixed test failure.
Comment #10
vikashsoni commentedPatch not applying need to Re-roll for drupal 9.3.x-dev
Comment #11
spokjeUnsure why, a test run I've started ended up green for 9.3 and 9.4.
RTBC-ing, updated Release notes snippet in IS to match the draft CR, updated draft CR version to 9.3.x and updated tags.
Comment #12
spokjeComment #15
alexpottCommitted and pushed 87fc0a7d04 to 10.0.x and d0be0af780 to 9.4.x. Thanks!
As this is an htaccess change we can only do this on Drupal 9.4.0 and 10.0.0 so committing there.
Comment #16
spokjeThanks @alexpott, changed Version meta-data of this issue accordingly