This is a placeholder for the 8.x-2.x patch for 2884674

CommentFileSizeAuthor
#8 3186027-3.patch2.71 KBharshit ghediya
#5 3186027-2.patch3.65 KBarnold.csisztai
#3 3186027.patch1.05 KBarnold.csisztai

Issue fork brightcove-3186027

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jan.mashat created an issue. See original summary.

arnold.csisztai made their first commit to this issue’s fork.

arnold.csisztai’s picture

arnold.csisztai commented
StatusFileSize
new 3186027.patch1.05 KB

arnold.csisztai opened merge request !1

arnold.csisztai’s picture

arnold.csisztai commented
StatusFileSize
new 3186027-2.patch3.65 KB
gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
commented
Related issues: +#2884674: Cover case with no configured players

Just Linking both issues
And tested this patch manually.

Above said issue from #2884674 is fixed

yce’s picture

yce commented
Status: Active » Fixed

Should be already fixed, closing the ticket.

harshit ghediya’s picture

harshit ghediya commented
Version: 8.x-2.x-dev » 3.x-dev
Status: Fixed » Needs review
StatusFileSize
new 3186027-3.patch2.71 KB

The patch #5 not working with 3.0.0-beta2 version. I got the same error on this version. Check below logs :

Error: Call to a member function isAdjusted() on null in Drupal\brightcove\Entity\BrightcovePlayer::createOrUpdate() (line 299 of modules\contrib\brightcove\src\Entity\BrightcovePlayer.php)

Re-rolling patch #5 to work with latest version.

Please review.

yce’s picture

yce commented
Status: Needs review » Needs work

Please create a merge request.

  • yce committed 34464b2 on do/3186027 
    Use player config only if set #3186027
yce’s picture

yce commented
Status: Needs work » Fixed

Nevermind, I've created a MR for 3.x: https://git.drupalcode.org/project/brightcove/-/merge_requests/16

  • yce committed 34464b2 on 3.x 
    Use player config only if set #3186027

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.