Closed (fixed)
Project:
Schema.org Metatag
Version:
8.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Nov 2020 at 12:52 UTC
Updated:
3 Mar 2022 at 21:19 UTC
Jump to comment: Most recent
Comments
Comment #2
bart vanhoutte commentedComment #3
denizserhat commentedI have the same problem. I made the change you mention, but in ACCEPTEDANSWER @type answer it does not have a Pivot option so all the answers appear below each question. How do I display Pivot?
Comment #4
joel_osc commentedThe patch fixed the issue for me and I am now seeing the problem mentioned by @denizerhat so I have opened a new issue on that here #3186311: Pivot on sub elements like images, FAQ answers etc so as not to muddy up this one. +1 for RBTC for this patch, thank-you!
Comment #5
denizserhat commentedthanks. I hope a solution is found
Comment #6
lindsay.wils commentedNot entirely sure of the issue, but I am trying to apply this patch as part of a composer update with cweagans/composer-patches, it fails locally, but when I push my code through circle, it applies successfully.
The error is not helpful.
"Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-11-17/faq-question.patch"
Has anyone else come across this issue?
If i manually apply the patch locally it works as expected
Comment #7
poindexterous commentedThis patch worked to resolve my issue. I noticed the fields were not appearing for the FAQ and QA page section of the schema metatag module fields inside of the node edit form.
@lindsay
I am also using cweagans/composer-patches in my project and this patch installed correctly using "composer install" after adding it to the patches section in my composer.json, the formatting I used appears to be exactly the same as yours but I have another patch installed for schema metatag
Is it just this patch that you've had problems with?
Comment #8
lindsay.wils commented@Poindexterous Thanks for the response, sorry I forgot to update this, turns out is was an issue with my setup, not the patch. I was able to apply it successfully, sorry for the confusion.
Comment #9
martygraphie commentedWork find thanks you !
Comment #10
it-cruPatch works for me with 8.x-2.2 release.
+1 for RTBC from me
Raised issue to major because without correct property_type schema_qa_page sub-module does not work correct.
Comment #12
wellsThanks, all! Patch committed. Appreciate any help also getting a patch and RTBC state for #3186311: Pivot on sub elements like images, FAQ answers etc now.