Problem/Motivation

When using 8.x-2.2, I'm unable to add a question to an FAQ tag, I just see a textfield for "MainEntity".

Proposed resolution

Add correct property_type question to schema_qa_page_main_entity annotation

CommentFileSizeAuthor
faq-question.patch580 bytesbart vanhoutte

Comments

Bart Vanhoutte created an issue. See original summary.

bart vanhoutte’s picture

Status: Active » Needs review
denizserhat’s picture

I have the same problem. I made the change you mention, but in ACCEPTEDANSWER @type answer it does not have a Pivot option so all the answers appear below each question. How do I display Pivot?

joel_osc’s picture

The patch fixed the issue for me and I am now seeing the problem mentioned by @denizerhat so I have opened a new issue on that here #3186311: Pivot on sub elements like images, FAQ answers etc so as not to muddy up this one. +1 for RBTC for this patch, thank-you!

denizserhat’s picture

thanks. I hope a solution is found

lindsay.wils’s picture

Not entirely sure of the issue, but I am trying to apply this patch as part of a composer update with cweagans/composer-patches, it fails locally, but when I push my code through circle, it applies successfully.

"extra":{
"patches": {
      "drupal/schema_metatag": {
        "Unable to add a question to FAQ page": "https://www.drupal.org/files/issues/2020-11-17/faq-question.patch"
      }
    }
}

The error is not helpful.
"Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-11-17/faq-question.patch"

Has anyone else come across this issue?

If i manually apply the patch locally it works as expected

poindexterous’s picture

This patch worked to resolve my issue. I noticed the fields were not appearing for the FAQ and QA page section of the schema metatag module fields inside of the node edit form.

@lindsay

I am also using cweagans/composer-patches in my project and this patch installed correctly using "composer install" after adding it to the patches section in my composer.json, the formatting I used appears to be exactly the same as yours but I have another patch installed for schema metatag

            "drupal/schema_metatag": {
                "Illegal offset type in Drupal\\schema_metatag\\SchemaMetatagClient->objectInfo()" : "https://www.drupal.org/files/issues/2020-09-30/schema_metatag-undefined_index_objectinfo-3174103-2.patch",
                "Unable to add a question to FAQ page." : "https://www.drupal.org/files/issues/2020-11-17/faq-question.patch"
            }

Is it just this patch that you've had problems with?

lindsay.wils’s picture

@Poindexterous Thanks for the response, sorry I forgot to update this, turns out is was an issue with my setup, not the patch. I was able to apply it successfully, sorry for the confusion.

martygraphie’s picture

Work find thanks you !

it-cru’s picture

Title: Unable to add a question to FAQ page. » Wrong property_type for schema_qa_page_main_entity
Priority: Normal » Major
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Patch works for me with 8.x-2.2 release.

+1 for RTBC from me

Raised issue to major because without correct property_type schema_qa_page sub-module does not work correct.

wells’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, all! Patch committed. Appreciate any help also getting a patch and RTBC state for #3186311: Pivot on sub elements like images, FAQ answers etc now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.