The Redirect Extensions module extends the Redirect module.

Extensions:

  • Adds tracking of 'Created By', 'Created Date', 'Updated By', 'Updated Date'.
  • Adds the ability to perform bulk updates on status code and destination URL.
  • Makes the 'To' URL a link.
  • Adds the ability export redirects to a CSV file.

Project link

https://www.drupal.org/project/redirect_extensions

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/redirect_extensions.git

Comments

rwsimmo created an issue. See original summary.

jimmy_sebastian’s picture

jimmy_sebastian commented
Status: Needs review » Needs work

@rwsimmo,

Please fix coding standard issues.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs work » Needs review

Reviews need to describe what need to be changed, not link to other issue reports.

baskaran’s picture

baskaran commented

@rwsimmo

Fix below coding standards by executing cbf command.

FILE: /Users/baskaran/Sites/devdesktop/drupal-8.8.1/modules/contrib/redirect_extensions/config/install/views.view.url_redirects.yml
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
961 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/baskaran/Sites/devdesktop/drupal-8.8.1/modules/contrib/redirect_extensions/tests/src/Unit/RedirectDatabaseStorageTest.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AND 1 WARNING AFFECTING 11 LINES
--------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
7 | ERROR | [x] Doc comment short description must end with a full stop
7 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
20 | ERROR | [x] Doc comment short description must end with a full stop
31 | ERROR | [x] Additional blank lines found at end of doc comment
34 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
59 | ERROR | [x] Missing function doc comment
60 | ERROR | [x] Opening brace should be on the same line as the declaration
64 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
66 | ERROR | [x] Expected 1 blank line after function; 2 found
69 | ERROR | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/baskaran/Sites/devdesktop/drupal-8.8.1/modules/contrib/redirect_extensions/README.txt
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
18 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /Users/baskaran/Sites/devdesktop/drupal-8.8.1/modules/contrib/redirect_extensions/src/Form/RedirectEditStatusForm.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------
80 | ERROR | [x] Multi-line function declarations must define one parameter per line
81 | ERROR | [x] Multi-line function declarations must define one parameter per line
82 | ERROR | [x] Multi-line function declarations must define one parameter per line
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------

FILE: /Users/baskaran/Sites/devdesktop/drupal-8.8.1/modules/contrib/redirect_extensions/src/RedirectDatabaseStorage.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------
29 | ERROR | [x] Doc comment short description must end with a full stop
35 | ERROR | [ ] Parameter $time is not described in comment
42 | ERROR | [ ] Missing parameter name
45 | ERROR | [x] Multi-line function declarations must define one parameter per line
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------

baskaran’s picture

baskaran commented
Status: Needs review » Needs work
rwsimmo’s picture

rwsimmo commented
Status: Needs work » Needs review

Thank you for the feedback. The issues have been fixed in the 1.9 release.

arshadkhan35’s picture

arshadkhan35 commented
Status: Needs review » Needs work

Hi @rwsimmo I still see some coding standard issue in unit test class as below, Please fix them.

FILE: .../redirect_extensions/tests/src/Unit/RedirectDatabaseStorageTest.php
---------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
 2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
 7 | ERROR | [x] Doc comment short description must end with a full stop
 7 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

Time: 273ms; Memory: 10MB
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

I am closing this application, as it hasn't been any reply in more than 4 months. Please reopen it once you made the requested changes, or the required changes are wrong.