Problem/Motivation

I'm having issues upgrading from Drupal 8.7.0 with Webform 8.x-5.1 directly to Drupal 8.9.3 with Webform 8.x-5.19. The error I get is coming from webform_update_8158().

>  [notice] Update started: webform_update_8158
>  [error]  Argument 2 passed to Drupal\pathauto\AliasStorageHelper::__construct() must be an instance of Drupal\path_alias\AliasRepositoryInterface, instance of Drupal\Core\Path\AliasRepository given

Steps to reproduce

TBC

Proposed resolution

Add an update dependency on system_update_8805() introduced in Drupal 8.8.0.

Remaining tasks

Confirm if this can be reproduced. Review and test patch.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#2 webform-3166248-update-dependencies.patch681 bytesmstrelan

Comments

mstrelan created an issue. See original summary.

mstrelan’s picture

Status: Active » Needs review
StatusFileSize
new681 bytes
mstrelan’s picture

Title: Error when webform_update_8158() runs before system_update_8805() » Error when webform_update_8158() runs before system_update_8803()

It seems system_update_8803() is the update we need to target, not system_update_8805(). I haven't updated the patch since I don't see any harm in requiring 8805. Seems cleaner to run all the system updates for Drupal 8.8.x together.

mstrelan’s picture

I've not been able to reproduce this on fresh Drupal install with the same versions, so possibly related to another contrib module and/or particularly content or configuration.

  • mstrelan authored 969945c on 8.x-5.x
    Issue #3166248 by mstrelan: Error when webform_update_8158() runs before...
jrockowitz’s picture

Status: Needs review » Fixed

Thanks for the patch.

  • mstrelan authored 969945c on 6.x
    Issue #3166248 by mstrelan: Error when webform_update_8158() runs before...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.